Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add token as part of the constructor #1

Open
alexisgayte opened this issue Jan 28, 2021 · 3 comments
Open

Add token as part of the constructor #1

alexisgayte opened this issue Jan 28, 2021 · 3 comments

Comments

@alexisgayte
Copy link

https://github.com/brianmcmichael/dss-vest/blob/f808e8a942305dcc3409f00cf320d06283a761d8/src/DssVest.sol#L9
@brianmcmichael
Copy link
Contributor

Yes, this might be better as an immutable variable set in the constructor so this can work with kovan. This is easier for governance participants to audit. If the goal is to generalize this for other projects I can see how that might be desirable, however.

@alexisgayte
Copy link
Author

Your code is not testable if it is hard coded.
That is another point to add ;)

@brianmcmichael
Copy link
Contributor

Added tests at 420cfd5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brianmcmichael @alexisgayte