Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not an issue but. #5

Open
alexisgayte opened this issue Jan 28, 2021 · 2 comments
Open

Not an issue but. #5

alexisgayte opened this issue Jan 28, 2021 · 2 comments

Comments

@alexisgayte
Copy link

https://github.com/brianmcmichael/dss-vest/blob/f808e8a942305dcc3409f00cf320d06283a761d8/src/DssVest.sol#L56

I would go for math lib instead of the comment.

@brianmcmichael
Copy link
Contributor

We're generally trying to avoid the safemath overhead when we know the numbers are safe. Here there's a require that ensures payment will be lower than amount, so the additional expense is unnecessary.

@alexisgayte
Copy link
Author

alexisgayte commented Jan 29, 2021

What happen if "pmt <= amt" check is removed, does your comment make it as safe as it looks? ;)
that was mainly also my point here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants