Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: seggregate scripts by launch phase #13

Merged
merged 16 commits into from
Nov 27, 2023
Merged

Refactor: seggregate scripts by launch phase #13

merged 16 commits into from
Nov 27, 2023

Conversation

amusingaxl
Copy link
Contributor

  • fix: add sanity checks for staking token and dss-vest
  • fix: add check for StakingRewards being updated before
  • refactor: seggregate scripts for different phases

@amusingaxl amusingaxl self-assigned this Oct 17, 2023
@amusingaxl
refactor: fully segregate scripts for different phases
1c388c0
@amusingaxl
refactor: rename scripts and template inputs
0a8a57b
@amusingaxl
fix: bad sanity check on phase-0/FarmingInit library
1dc0f96
@amusingaxl
refactor: change internal name for StakingRewards instances
8963b19
@amusingaxl
refactor(phase-0-alpha): remove creation of vesting stream
d8c0d62 
`vestId` is expected as an input parameter instead. This makes it easier, since another team deployed the `DssVest` contract for NGT tokens.
@amusingaxl
chore: update lib/dss-test
6a91517
@amusingaxl
fix(phase-0-alpha): adjust init and check script after deloy refactor
f799377
@amusingaxl
refactor(ConfigReader): swap envOrRead* parameters
eeb1771 
Since env vars take priority, `envKey` should be the 1st parameter.
@amusingaxl
docs(phase-0): add comment for assumption on vest
74277b9
@amusingaxl
refactor(phase-0): update deploy script input template
5dc625f
0xp3th1um
0xp3th1um approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@0xp3th1um 0xp3th1um left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (just left a single comment)

script/dependencies/phase-0-alpha/FarmingInit.sol Show resolved Hide resolved
@amusingaxl
refactor(solc-version): use 0.8.16
92670dd 
Use `solc`@`0.8.16` to match the remaining endgame related contracts
@amusingaxl
refactor(VestInit): remove unused dependency
f95d2fa
@amusingaxl amusingaxl merged commit 2c20e25 into master Nov 27, 2023
1 check passed
@amusingaxl amusingaxl deleted the refactor/chainsecurity-audit branch November 27, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xdecr1pto 0xdecr1pto 0xdecr1pto approved these changes

@0xp3th1um 0xp3th1um 0xp3th1um approved these changes

Assignees

@amusingaxl amusingaxl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amusingaxl @0xdecr1pto @0xp3th1um