rearrange env variable as suggested

makerdao · Jan 23, 2024 · 0cd3047 · 0cd3047
1 parent 0017d8e
commit 0cd3047
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/spell/spell-reviewer-mainnet-checklist.md b/spell/spell-reviewer-mainnet-checklist.md
@@ -317,8 +317,8 @@
   * [ ] Ensure that the `DssExecLib.address` file is not being modified by the spell PR
   * [ ] Check all CI tests are passing as at the latest commit
     _Insert most recent commit hash where CI was passing_
-  * [ ] Check all tests are passing locally using `make test`
   * [ ] Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of `printenv | grep "FOUNDRY_\|DAPP_"`)
+  * [ ] Check all tests are passing locally using `make test`
 
 ```bash
 _Insert your local test logs here_
@@ -357,8 +357,8 @@ _Insert your local test logs here_
   * [ ] Ensure that the `DssExecLib.address` file is not being modified by the spell PR
   * [ ] Check all CI tests are passing as at the latest commit
     _Insert most recent commit hash where CI was passing_
+  * [ ] Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of `printenv | grep "FOUNDRY_\|DAPP_"`)
   * [ ] Check all tests are passing locally using `make test`
-  * [ ] Ensure that `make test` output displays every optional parameter is unset (ie first output line of `make test` is `./scripts/test-dssspell-forge.sh no-match="" match="" block=""`)
 
 ```bash
 _Insert your local test logs here_