Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: amusingaxl <112016538+amusingaxl@users.noreply.github.com>
  • Loading branch information
SidestreamSweatyPumpkin and amusingaxl authored Oct 25, 2023
1 parent 39951d4 commit 8078884
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 7 deletions.
8 changes: 6 additions & 2 deletions spell/spell-reviewer-goerli-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -228,15 +228,17 @@ Spell Actions (Per Exec Sheet):
* [ ] Spell actions match the corresponding [Exec Sheet](https://docs.google.com/spreadsheets/d/1w_z5WpqxzwreCcaveB2Ye1PP5B8QAHDglzyxKHG3CHw)
* [ ] Tests
* [ ] Ensure each spell action has sufficient test coverage
_List actions for which coverage was checked here_
_List actions for which coverage was checked here_
* [ ] Ensure every test function is declared as public if enabled or private if disabled
* [ ] Ensure that the `DssExecLib.address` file is not being modified by the spell PR
* [ ] Check all CI tests are passing as at the latest commit
_Insert most recent commit hash where CI was passing_
_Insert most recent commit hash where CI was passing_
* [ ] Check all tests are passing locally using `make test`
* [ ] Ensure that only `ETH_RPC_URL` is being used from env (i.e. no `match`, `block` or similar are active in your env)

```
_Insert your passing local tests here_
```

## Deployed Stage

Expand Down Expand Up @@ -271,7 +273,9 @@ _Insert your passing local tests here_
* [ ] Check all tests are passing locally using `make test`
* [ ] Ensure that only `ETH_RPC_URL` is being used from env (i.e. no `match`, `block` or similar are active in your env)

```
_Insert your passing local tests here_
```

## Cast and Merge Stage

Expand Down
10 changes: 5 additions & 5 deletions spell/spell-reviewer-mainnet-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ Spell Actions (Per Exec Doc):
* [ ] Reinstall libraries
* [ ] Remove libraries by deleting the `lib` folder
* [ ] Install libraries using `git submodule update --init --recursive`
```
Insert checked out submodule paths here
```
```
Insert checked out submodule paths here
```
* [ ] Dependency checks
* [ ] `dss-exec-lib`
* [ ] if submodule upgrades are present make sure `dss-exec-lib` is synced as well
Expand Down Expand Up @@ -140,10 +140,10 @@ Spell Actions (Per Exec Doc):
* [ ] [`decreaseGlobalDebtCeiling`](https://github.com/makerdao/dss-exec-lib/blob/c0d3c6c6244468ddab9767de6f853122723fafda/src/DssExecLib.sol#L445C14-L445C39)
* [ ] `amount`
Autoline Changes
* [setIlkAutoLineDebtCeiling](https://github.com/makerdao/dss-exec-lib/blob/v0.0.9/src/DssExecLib.sol#L658)
* [ ] [setIlkAutoLineDebtCeiling](https://github.com/makerdao/dss-exec-lib/blob/v0.0.9/src/DssExecLib.sol#L658)
* [ ] `ilk`
* [ ] `line`
* [setIlkAutoLineParameters](https://github.com/makerdao/dss-exec-lib/blob/v0.0.9/src/DssExecLib.sol#L648)
* [ ] [setIlkAutoLineParameters](https://github.com/makerdao/dss-exec-lib/blob/v0.0.9/src/DssExecLib.sol#L648)
* [ ] `ilk`
* [ ] `line`
* [ ] `gap`
Expand Down

0 comments on commit 8078884

Please sign in to comment.