From 98825cf3dfd6db5459f445afb03e606719808927 Mon Sep 17 00:00:00 2001 From: 0x3phemeralsoul <118270473+0x3phemeralsoul@users.noreply.github.com> Date: Tue, 21 May 2024 12:40:54 +0200 Subject: [PATCH 1/3] Update spell-crafter-mainnet-workflow.md Minor change. From All to Crafter. If we put ALL, then it is no one's responsibility. so I prefer that the Crafter starts the retro. From (if needed) to Always: Retro's should always happen, if not, starting a retro can be perceived as finger pointing. Also, if the retro is mandatory, it forces ppl to raise topics before they become a bigger issue that would create discomfort. Having a retro as a habit generates a place for psychological safety where members can share anything, even if it is not a big deal. If there is nothing to discuss in the retro, then a simple one-liner by the Crafter: "Retro:Nothing to discuss" is enough, the rest can thumbs up or share something from their side. --- spell/spell-crafter-mainnet-workflow.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spell/spell-crafter-mainnet-workflow.md b/spell/spell-crafter-mainnet-workflow.md index 88fa9bc1..5658d70e 100644 --- a/spell/spell-crafter-mainnet-workflow.md +++ b/spell/spell-crafter-mainnet-workflow.md @@ -25,7 +25,7 @@ Repo: https://github.com/makerdao/spells-mainnet | Governance | Spell address is received | 16:00-16:30 UTC Week 2 Thursday | | Reviewers | Spell PR is approved | 16:00-16:30 UTC Week 2 Thursday | | Crafter | Spell PR is merged | 16:00-16:30 UTC Week 2 Thursday | -| All | Spell retro is started (if needed) | 12:00 UTC Week 2 Friday | +| Crafter | Spell retro is started always on every spell cycle | 12:00 UTC Week 2 Friday | - The deadlines are only meant for better coordination and should not be prioritised over security - If a delay is expected, responsible party should provide new realistic time estimation From 0e88860614a01af8def299da0a271b99e59a3b5c Mon Sep 17 00:00:00 2001 From: SidestreamColdMelon Date: Thu, 23 May 2024 10:56:58 +0200 Subject: [PATCH 2/3] apply suggested changes --- spell/spell-crafter-mainnet-workflow.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/spell/spell-crafter-mainnet-workflow.md b/spell/spell-crafter-mainnet-workflow.md index bfac00ba..c5ae4342 100644 --- a/spell/spell-crafter-mainnet-workflow.md +++ b/spell/spell-crafter-mainnet-workflow.md @@ -25,7 +25,7 @@ Repo: https://github.com/makerdao/spells-mainnet | Governance | Spell address is received | 16:00-16:30 UTC Week 2 Thursday | | Reviewers | Spell PR is approved | 16:00-16:30 UTC Week 2 Thursday | | Crafter | Spell PR is merged | 16:00-16:30 UTC Week 2 Thursday | -| Crafter | Spell retro is started always on every spell cycle | 12:00 UTC Week 2 Friday | +| Crafter | Spell retro is started | 16:30 UTC Week 2 Thursday | - The deadlines are only meant for better coordination and should not be prioritised over security - If a delay is expected, responsible party should provide new realistic time estimation @@ -220,7 +220,10 @@ Repo: https://github.com/makerdao/spells-mainnet * [ ] Squash & Merge ## Next Steps - +* [ ] Initiate spell retrospective (inside existing spell thread in the #govops discord channel) + * Collect any problems noticed during the spell, propose concrete improvements to make it constructive + * Prefix your message with `Initiating retro:` for clarity + * IF there is nothing to discuss, post `Initiating retro: nothing to discuss from my side` * IF [`MegaPoker`-related](https://github.com/makerdao/megapoker/blob/master/src/MegaPoker.sol) updates are present in the spell (oracles are replaced, collaterals are onboarded or offboarded, etc) * [ ] Inform EA responsible for maintaining `MegaPoker` contract * Ensure `MegaPoker` contract is updated From 90089c6d7678847accf926c7c7585c72741a596e Mon Sep 17 00:00:00 2001 From: SidestreamColdMelon Date: Thu, 23 May 2024 10:58:37 +0200 Subject: [PATCH 3/3] fix typecheck --- spell/spell-crafter-mainnet-workflow.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spell/spell-crafter-mainnet-workflow.md b/spell/spell-crafter-mainnet-workflow.md index c5ae4342..88494c9a 100644 --- a/spell/spell-crafter-mainnet-workflow.md +++ b/spell/spell-crafter-mainnet-workflow.md @@ -220,7 +220,7 @@ Repo: https://github.com/makerdao/spells-mainnet * [ ] Squash & Merge ## Next Steps -* [ ] Initiate spell retrospective (inside existing spell thread in the #govops discord channel) +* [ ] Initiate spell retrospective (inside existing spell thread in the `#govops` discord channel) * Collect any problems noticed during the spell, propose concrete improvements to make it constructive * Prefix your message with `Initiating retro:` for clarity * IF there is nothing to discuss, post `Initiating retro: nothing to discuss from my side`