Skip to content

Commit

Permalink
Removed 'script this eventually' message but retained context for rev…
Browse files Browse the repository at this point in the history
…iewer concern
  • Loading branch information
The-Arbiter committed Jul 27, 2023
1 parent f5941fc commit 91ff7d9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion spell/spell-reviewer-goerli-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ Spell Actions:
* [ ] Execution is NOT delegate call
* [ ] Gas cost will not be too high (low level call gas estimation is not done by our scripts)
* [ ] Maker Core (main spell) SubDAO actions (i.e. operate in Pause Proxy `DelegateCall` context)
* [ ] No SubDAO contract being interacted with is authed on a core contract like vat, etc. (script this eventually)
* [ ] No SubDAO contract being interacted with is authed on a core contract like vat, etc. (Check comprehensively where the risk is high)
* [ ] SubDAO contract licensing and optimizations do not matter (not strictly)
* [ ] SubDAO contracts and all libraries / dependencies are verified (Blocking if not true)
* [ ] Upgradable SubDAO contracts
Expand Down
2 changes: 1 addition & 1 deletion spell/spell-reviewer-mainnet-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ Spell Actions:
* [ ] Execution is NOT delegate call
* [ ] Gas cost will not be too high (low level call gas estimation is not done by our scripts)
* [ ] Maker Core (main spell) SubDAO actions (i.e. operate in Pause Proxy `DelegateCall` context)
* [ ] No SubDAO contract being interacted with is authed on a core contract like vat, etc. (script this eventually)
* [ ] No SubDAO contract being interacted with is authed on a core contract like vat, etc. (Check comprehensively where the risk is high)
* [ ] SubDAO contract licensing and optimizations do not matter (not strictly)
* [ ] SubDAO contracts and all libraries / dependencies are verified (Blocking if not true)
* [ ] Upgradable SubDAO contracts
Expand Down

0 comments on commit 91ff7d9

Please sign in to comment.