Improve handover procedure (#19)

makerdao · Jan 30, 2024 · b0a283c · b0a283c
1 parent 1049ef1
commit b0a283c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/spell/spell-crafter-mainnet-workflow.md b/spell/spell-crafter-mainnet-workflow.md
@@ -169,7 +169,9 @@ Repo: https://github.com/makerdao/spells-mainnet
 * [ ] Commit & Push for Review
 * [ ] Wait for CI to PASS
 * [ ] Wait for at Least two Approvals to Share for Publishing to Governance Facilitators
-* [ ] Share Deployed Address in `new-spells`
+* [ ] Share Deployed Address in [`new-spells`](https://discord.com/channels/893112320329396265/897483518316265553) discord channel
+  * [ ] Make sure to tag responsible governance facilitator in the message with the address
+  * [ ] Wait until responsible governance facilitator confirms handover in `new-spells`
 * [ ] Fill the rest of the Spell Crafter Related Boxes in the Main Exec Sheet
 * [ ] Pre-Merge Target Branch Pull Attack Checks
   * [ ] Ensure that the latest commit to the spells-mainnet repo was not a maintenance PR

diff --git a/spell/spell-reviewer-mainnet-checklist.md b/spell/spell-reviewer-mainnet-checklist.md
@@ -368,5 +368,6 @@ _Insert your local test logs here_
 
 * [ ] Check that the spell address posted by the crafter in [`new-spells`](https://discord.com/channels/893112320329396265/897483518316265553) is correct
 * [ ] Confirm the address in the [`new-spells`](https://discord.com/channels/893112320329396265/897483518316265553) channel (via a separate "reply to" message, restating the address to avoid edits)
+  * [ ] Wait until responsible governance facilitator confirms handover in `new-spells`
 * [ ] Ensure that no changes were made to the code since the spell was deployed and archived
 * [ ] Approve spell PR for merge via 'Approve' review option