From b0a283cd0331d30b2a397475fd5aa39c09396253 Mon Sep 17 00:00:00 2001 From: SidestreamColdMelon <132689270+SidestreamColdMelon@users.noreply.github.com> Date: Tue, 30 Jan 2024 14:43:13 +0100 Subject: [PATCH] Improve handover procedure (#19) --- spell/spell-crafter-mainnet-workflow.md | 4 +++- spell/spell-reviewer-mainnet-checklist.md | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/spell/spell-crafter-mainnet-workflow.md b/spell/spell-crafter-mainnet-workflow.md index 6589a416..32dac88d 100644 --- a/spell/spell-crafter-mainnet-workflow.md +++ b/spell/spell-crafter-mainnet-workflow.md @@ -169,7 +169,9 @@ Repo: https://github.com/makerdao/spells-mainnet * [ ] Commit & Push for Review * [ ] Wait for CI to PASS * [ ] Wait for at Least two Approvals to Share for Publishing to Governance Facilitators -* [ ] Share Deployed Address in `new-spells` +* [ ] Share Deployed Address in [`new-spells`](https://discord.com/channels/893112320329396265/897483518316265553) discord channel + * [ ] Make sure to tag responsible governance facilitator in the message with the address + * [ ] Wait until responsible governance facilitator confirms handover in `new-spells` * [ ] Fill the rest of the Spell Crafter Related Boxes in the Main Exec Sheet * [ ] Pre-Merge Target Branch Pull Attack Checks * [ ] Ensure that the latest commit to the spells-mainnet repo was not a maintenance PR diff --git a/spell/spell-reviewer-mainnet-checklist.md b/spell/spell-reviewer-mainnet-checklist.md index 8cb6984a..99b82604 100644 --- a/spell/spell-reviewer-mainnet-checklist.md +++ b/spell/spell-reviewer-mainnet-checklist.md @@ -368,5 +368,6 @@ _Insert your local test logs here_ * [ ] Check that the spell address posted by the crafter in [`new-spells`](https://discord.com/channels/893112320329396265/897483518316265553) is correct * [ ] Confirm the address in the [`new-spells`](https://discord.com/channels/893112320329396265/897483518316265553) channel (via a separate "reply to" message, restating the address to avoid edits) + * [ ] Wait until responsible governance facilitator confirms handover in `new-spells` * [ ] Ensure that no changes were made to the code since the spell was deployed and archived * [ ] Approve spell PR for merge via 'Approve' review option