Skip to content

Commit

Permalink
chore: rephrase
Browse files Browse the repository at this point in the history
  • Loading branch information
Sweaty Pumpkin authored and Sweaty Pumpkin committed Nov 7, 2023
1 parent 77b7aa3 commit b29eec6
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion spell/spell-crafter-goerli-workflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ PR: https://github.com/makerdao/spells-goerli/pull/<TODO>
* [ ] `Forum:` if URL starts with `https://forum.makerdao.com/t/`
* [ ] `MIP:` if URL starts with `https://mips.makerdao.com/mips/details/`
* [ ] If action in the spell doesn't have relevant instruction (e.g.: `chainlog` version bump), it add explanation prefixed with `// Note:`
* [ ] If an instruction can not be taken, a note add under the instruction prefixed with `// Note: ` (e.g.: `// Note: Skip payments on goerli`)
* [ ] If an instruction can not be taken, add a comment under the instruction prefixed with `// Note:` (e.g.: `// Note: Payments are skipped on goerli`)
* [ ] Adjust System Values, Collateral Values in `config.sol` (i.e. diffcheck via vscode `code --diff config1.sol config2.sol`) with `spells-mainnet`)
* [ ] Add Specific Tests in `DssSpell.t.sol` (i.e. diffcheck via vscode `code --diff source1.sol source2.sol`) with `spells-mainnet`)
* [ ] Add new collateral tests
Expand Down
2 changes: 1 addition & 1 deletion spell/spell-crafter-mainnet-workflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ Repo: https://github.com/makerdao/spells-mainnet
* [ ] `Forum:` if URL starts with `https://forum.makerdao.com/t/`
* [ ] `MIP:` if URL starts with `https://mips.makerdao.com/mips/details/`
* [ ] If action in the spell doesn't have relevant instruction (e.g.: `chainlog` version bump), it add explanation prefixed with `// Note:`
* [ ] If an instruction can not be taken, a note add under the instruction prefixed with `// Note: ` (e.g.: `// Note: Skip payments on goerli`)
* [ ] If an instruction can not be taken, add a comment under the instruction prefixed with `// Note:` (e.g.: `// Note: Payments are skipped on goerli`)
* [ ] Adjust System Values, Collateral Values in `config.sol` (i.e. diffcheck via vscode `code --diff config1.sol config2.sol`) with `spells-goerli`)
* [ ] Add Specific Tests in `DssSpell.t.sol` (i.e. diffcheck via vscode `code --diff source1.sol source2.sol`) with `spells-goerli`)
* [ ] Add new collateral tests
Expand Down
2 changes: 1 addition & 1 deletion spell/spell-reviewer-goerli-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ Spell Actions (Per Exec Sheet):
* [ ] `Forum:` if URL starts with `https://forum.makerdao.com/t/`
* [ ] `MIP:` if URL starts with `https://mips.makerdao.com/mips/details/`
* [ ] If action in the spell doesn't have relevant instruction (e.g.: `chainlog` version bump), it should have explanation prefixed with `// Note:`
* [ ] If an instruction can not be taken, a note should be added under the instruction prefixed with `// Note: ` (e.g.: `// Note: Skip payments on goerli`)
* [ ] If an instruction can not be taken, add a comment under the instruction prefixed with `// Note:` (e.g.: `// Note: Payments are skipped on goerli`)
* [ ] String Constants
* [ ] IPFS hashes or DAO resolutions
* [ ] IPFS hashes and DAO resolutions match the exec doc
Expand Down
2 changes: 1 addition & 1 deletion spell/spell-reviewer-mainnet-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ Spell Actions (Per Exec Doc):
* [ ] `Forum:` if URL starts with `https://forum.makerdao.com/t/`
* [ ] `MIP:` if URL starts with `https://mips.makerdao.com/mips/details/`
* [ ] If action in the spell doesn't have relevant instruction (e.g.: `chainlog` version bump), it should have explanation prefixed with `// Note:`
* [ ] If an instruction can not be taken, a note should be added under the instruction prefixed with `// Note: ` (e.g.: `// Note: Skip payments on goerli`)
* [ ] If an instruction can not be taken, add a comment under the instruction prefixed with `// Note:` (e.g.: `// Note: Payments are skipped on goerli`)
* [ ] Rate constants used are correct
* [ ] Manual check 1: using `make rates pct=<pct>` (e.g. pct=0.75, for 0.75%)
* [ ] Manual check 2: Compare against [IPFS](https://ipfs.io/ipfs/QmVp4mhhbwWGTfbh2BzwQB9eiBrQBKiqcPRZCaAxNUaar6)
Expand Down

0 comments on commit b29eec6

Please sign in to comment.