Update crafters checklist #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SidestreamColdMelon
requested review from
oddaf,
amusingaxl,
0xdecr1pto and
0xp3th1um
amusingaxl
reviewed
May 14, 2024
| * [ ] Check local env | ||
| * EIP1559 | ||
| * [ ] Run `make estimate` to estimate gas | ||
| * [ ] `export ETH_GAS=X` with the output of the command above (e.g. `export ETH_GAS=6_000_000`) |
There was a problem hiding this comment.
Gas estimations might not be 100% accurate:
Suggested change
| * [ ] `export ETH_GAS=X` with the output of the command above (e.g. `export ETH_GAS=6_000_000`) | |
| * [ ] `export ETH_GAS=X` with the output of the command above + a safety margin (e.g. `export ETH_GAS=6_000_000`) |
amusingaxl
reviewed
May 14, 2024
| * EIP1559 | ||
| * [ ] Run `make estimate` to estimate gas | ||
| * [ ] `export ETH_GAS=X` with the output of the command above (e.g. `export ETH_GAS=6_000_000`) | ||
| * [ ] Check current gas price using `seth gas-price` and set `ETH_GAS_PRICE` accordingly (e.g. `50 gwei`) |
There was a problem hiding this comment.
Wouldn't it be better to fetch it from the same source as the priority fee?
There was a problem hiding this comment.
It might be, but the aim of this PR is to just improve the structure or in some cases add/improve rules, but not change them, so I would put this out of scope 🙂
amusingaxl
reviewed
May 14, 2024
| * [ ] Set `deployed_spell` to `address(0)` | ||
| * [ ] Set `deployed_spell_created` to `0` | ||
| * [ ] Set `deployed_spell_block` to `0` | ||
| * [ ] Consider to add `previous_spell` address IF it haven't been executed yet |
There was a problem hiding this comment.
Suggested change
| * [ ] Consider to add `previous_spell` address IF it haven't been executed yet | |
| * [ ] IF there are outstanding spells that have not been cast yet, add them to `previous_spells`. |
0xdecr1pto
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27. A follow up to #18.