Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tenderly Env vars to spell crafter checklist #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oddaf
Copy link
Member

@oddaf oddaf commented Jun 26, 2024

On the latest spell I spent quite a bit of time trying to use my Tenderly user ID in the env var TENDERLY_USER, when I should be using my team's ID instead. This PR updates the checklist to detail what goes in each of the ENV vars in a way similar to the deployment script section.

Comment on lines 191 to +194
* Cast spell on a newly created Tenderly Testnet
* [ ] `export TENDERLY_USER='<ORG_SLUG>'` (e.g.: dewiz-xyz)
* [ ] `export TENDERLY_PROJECT='makerdao'`
* [ ] `export TENDERLY_ACCESS_KEY='<ACCESS_KEY>'` (from the **account level**, not from the organization level)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think checklist is a good place to store env variables and setup instructions:

  • Setup only needs to happen once while every checklist item suppose to be followed every single time
  • Code of the tenderly script lays in a different repository so it's harder to maintain two places in sync

Instead, you can link a readme section that already explains that:

Suggested change
* Cast spell on a newly created Tenderly Testnet
* [ ] `export TENDERLY_USER='<ORG_SLUG>'` (e.g.: dewiz-xyz)
* [ ] `export TENDERLY_PROJECT='makerdao'`
* [ ] `export TENDERLY_ACCESS_KEY='<ACCESS_KEY>'` (from the **account level**, not from the organization level)
* Cast spell on a newly created Tenderly Testnet (see [setup instructions](https://github.com/makerdao/spells-mainnet?tab=readme-ov-file#cast-to-tenderly))

Alternatively, you can submit a PR into makerdao/spells-mainnet to move this setup instructions into a more visible place (eg inside relevant folder)

@DaiFoundation-DevOps
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants