Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tenderly Env vars to spell crafter checklist #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Tenderly Env vars to spell crafter checklist #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions spell/spell-crafter-mainnet-workflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,9 @@ Repo: https://github.com/makerdao/spells-mainnet
* [ ] Ensure local tests PASS against deployed spell run via the deploy script
* [ ] Push auto-generated `add deployed spell info` commit
* Cast spell on a newly created Tenderly Testnet
* [ ] `export TENDERLY_USER='<ORG_SLUG>'` (e.g.: dewiz-xyz)
* [ ] `export TENDERLY_PROJECT='makerdao'`
* [ ] `export TENDERLY_ACCESS_KEY='<ACCESS_KEY>'` (from the **account level**, not from the organization level)
Comment on lines 191 to +194
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think checklist is a good place to store env variables and setup instructions:

  • Setup only needs to happen once while every checklist item suppose to be followed every single time
  • Code of the tenderly script lays in a different repository so it's harder to maintain two places in sync

Instead, you can link a readme section that already explains that:

Suggested change
* Cast spell on a newly created Tenderly Testnet
* [ ] `export TENDERLY_USER='<ORG_SLUG>'` (e.g.: dewiz-xyz)
* [ ] `export TENDERLY_PROJECT='makerdao'`
* [ ] `export TENDERLY_ACCESS_KEY='<ACCESS_KEY>'` (from the **account level**, not from the organization level)
* Cast spell on a newly created Tenderly Testnet (see [setup instructions](https://github.com/makerdao/spells-mainnet?tab=readme-ov-file#cast-to-tenderly))

Alternatively, you can submit a PR into makerdao/spells-mainnet to move this setup instructions into a more visible place (eg inside relevant folder)

* [ ] Create testnet and cast deployed spell there using `make cast-on-tenderly spell=0x...` command
* [ ] Check that returned `public explorer url` is publicly accessible (e.g. using incognito browser mode)
* [ ] IF `cast-on-tenderly` command is executed several times for the same spell, delete all testnets of the same name except the last one
Expand Down
Loading