Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboard multi swap conduit for RWA015-A & Cleanup old conduits #357

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Onboard multi swap conduit for RWA015-A & Cleanup old conduits #357

merged 2 commits into from
Jul 10, 2023

Conversation

0xdecr1pto
Copy link
Contributor

Description

Contribution Checklist

  • PR title starts with (PE-<TICKET_NUMBER>)
  • Code approved
  • Tests approved
  • CI Tests pass

Checklist

  • Every contract variable/method declared as public/external private/internal
  • Consider if this PR needs the officeHours modifier override
  • Verify expiration (30 days unless otherwise specified)
  • Verify hash in the description matches here
  • Validate all addresses used are in changelog or known
  • Notify any external teams affected by the spell so they have the opportunity to review
  • Deploy spell ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
  • Verify mainnet contract on etherscan
  • Change test to use mainnet spell address and deploy timestamp
  • Run make archive-spell or make date="YYYY-MM-DD" archive-spell to make an archive directory and copy DssSpell.sol, DssSpell.t.sol, DssSpell.t.base.sol, and DssSpellCollateralOnboarding.sol
  • squash and merge this PR

@0xdecr1pto 0xdecr1pto self-assigned this Jul 6, 2023
@0xdecr1pto 0xdecr1pto changed the title Oonboard multi swap conduit to RWA015-A & Cleanup old conduits Onboard multi swap conduit to RWA015-A & Cleanup old conduits Jul 6, 2023
@0xdecr1pto 0xdecr1pto changed the title Onboard multi swap conduit to RWA015-A & Cleanup old conduits Onboard multi swap conduit for RWA015-A & Cleanup old conduits Jul 6, 2023
@SidestreamColdMelon SidestreamColdMelon merged commit 483421a into 2023-07-12 Jul 10, 2023
2 checks passed
@SidestreamColdMelon SidestreamColdMelon deleted the feat/rwa015-multiswap-conduit branch July 10, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0xdecr1pto 0xdecr1pto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xdecr1pto @SidestreamColdMelon