-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mainnet spell 2024-09-05 #423
Conversation
Good to deploy Development Stage
Pre-Deployment Stage
|
TLDR: Good to deploy Mainnet Executive Spell Review ChecklistDevelopment Stage
Pre-Deployment Stage
|
The spell is deployed to: 0x900c952c676595DdB392FA6349aD5f0674a67Eeb |
TLDR: Good to handover Deployed Stage
|
Good to handover Deployed Stage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handover and Merge Stage
- Check that the spell address posted by the crafter in
new-spells
is correct - Confirm the address in the
new-spells
channel (via a separate "reply to" message, restating the address to avoid edits)- Wait until responsible governance facilitator confirms handover in
new-spells
- Wait until responsible governance facilitator confirms handover in
- Ensure that no changes were made to the code since the spell was deployed and archived
- Approve spell PR for merge via 'Approve' review option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge :)
Handover and Merge Stage
- Check that the spell address posted by the crafter in
new-spells
is correct - Confirm the address in the
new-spells
channel (via a separate "reply to" message, restating the address to avoid edits)- Wait until responsible governance facilitator confirms handover in
new-spells
- Wait until responsible governance facilitator confirms handover in
- Ensure that no changes were made to the code since the spell was deployed and archved
- Approve spell PR for merge via 'Approve' review option
Description
This PR implements the 2024-09-05 mainnet spell based on the relevant exec sheet
Contribution Checklist
(PE-<TICKET_NUMBER>)
Checklist
officeHours
modifier override30 days
unless otherwise specified)ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploy
mainnet
contract on etherscanmake archive-spell
ormake date="YYYY-MM-DD" archive-spell
to make an archive directory and copyDssSpell.sol
,DssSpell.t.sol
,DssSpell.t.base.sol
, andDssSpellCollateralOnboarding.sol
squash and merge
this PR