Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vanieth should check vanity address characters are valid ([:digit:abcdef]) #3

Open
igponce opened this issue Jun 17, 2021 · 3 comments

Comments

@igponce
Copy link

igponce commented Jun 17, 2021

Running vanieth with characters that cannot be part of an Ethereum address should return an error.

For instance, running:

$ vanieth feo -n25

should return an error. It could even suggest a substitution:

$ vanieth feo -n25
vanieth feo
           ^
Error: 'o' is not a valid character for Ethereum addresses. Did you mean '0' ?
@igponce
Copy link
Author

igponce commented Jun 17, 2021

(can you please assing this issue to me ? ;-)

@makevoid
Copy link
Owner

yes it would be a nice feature to have :)

if no one does a PR for this it I will code it at some point

@igponce
Copy link
Author

igponce commented Nov 16, 2021

PR Sent!

I didn't coded the suggestion :-( and there are a lot of cases where you can specify a regex that will never match an ethereum addres; but at least the CPU won't be red hot looking for a substring that cannot be part of an address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants