Skip to content

Commit

Permalink
Merge branch 'dev' of https://github.com/maks-sh/scikit-uplift into dev
Browse files Browse the repository at this point in the history
  • Loading branch information
maks-sh committed Apr 29, 2021
2 parents aeb9bec + 255d710 commit fe2fe62
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion sklift/datasets/datasets.py
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ def fetch_x5(data_home=None, dest_subdir=None, download_if_missing=True):
dest_filename=file_clients,
download_if_missing=download_if_missing)
clients = pd.read_csv(csv_clients_path)
clients_features = list(clients.column)
clients_features = list(clients.columns)

url_purchases = 'https://timds.s3.eu-central-1.amazonaws.com/purchases.csv.gz'
file_purchases = url_purchases.split('/')[-1]
Expand Down
2 changes: 1 addition & 1 deletion sklift/metrics/metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ def uplift_by_percentile(y_true, uplift, treatment, strategy='overall',
std (bool): If True, add columns with the uplift standard deviation and the response rate standard deviation.
Default is False.
total (bool): If True, add the last row with the total values. Default is False.
The total uplift is a weighted average uplift. See :func:`.weighted_average_uplift`.
The total uplift computes as a total response rate treatment - a total response rate control.
The total response rate is a response rate on the full data amount.
bins (int): Determines the number of bins (and the relative percentile) in the data. Default is 10.
string_percentiles (bool): type of percentiles in the index: float or string. Default is True (string).
Expand Down
1 change: 0 additions & 1 deletion sklift/viz/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ def plot_uplift_preds(trmnt_preds, ctrl_preds, log=False, bins=100):

# TODO: Add k as parameter: vertical line on plots
check_consistent_length(trmnt_preds, ctrl_preds)
check_is_binary(treatment)

if not isinstance(bins, int) or bins <= 0:
raise ValueError(
Expand Down

0 comments on commit fe2fe62

Please sign in to comment.