Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of ACE descriptors #529

Draft
wants to merge 22 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions mala/common/parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,35 @@ def __init__(self):
self.minterpy_polynomial_degree = 4
self.minterpy_lp_norm = 2

# ace descriptors
self.ace_elements = ["Al", "G"]
self.ace_mumax = len(self.ace_elements)
self.ace_ranks = [1, 2, 3]
self.ace_nmax = [6, 2, 2]
self.ace_lmax = [0, 2, 2]
self.ace_nradbase = max(self.ace_nmax)
self.ace_lmin = [0, 0, 0]
self.ace_reference_ens = [0.0, 0.0]

self.ace_nshell = 2.0
self.ace_apply_shift = False
self.ace_metal_max = True
self.ace_use_vdw = False

self.ace_L_R = 0
self.ace_M_R = 0

self.ace_coupling_type = "cg"
self.ace_lmax_traditional = 12

# TODO: add consistency check for these
# if grid_filter, types_like_snap must be False
# if grid_filter, padfunc must be True
self.ace_grid_filter = True
self.ace_types_like_snap = False
self.ace_padfunc = True


@property
def use_z_splitting(self):
"""
Expand Down
2 changes: 2 additions & 0 deletions mala/descriptors/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@
from .atomic_density import AtomicDensity
from .descriptor import Descriptor
from .minterpy_descriptors import MinterpyDescriptors
from .ace import ACE
from .ace_potential import AcePot
Loading