From 0f4a55c3b88b38ed8040764998c9e1f2f7853f98 Mon Sep 17 00:00:00 2001 From: Max Brauer Date: Tue, 14 May 2024 10:38:17 +0200 Subject: [PATCH] Limit session IDs to a non-negative, pseudo-random int32 Technically, this reduces the set from which session IDs are drawn by (9.999.999.999 - 2.147.483.647) = 7.852.516.352, say 75%. Practically, ~2 million should large enough to avoid collisions in the real-world. This fixes an int overflow for 386 architectures. Fixes #663 Signed-off-by: Max Brauer --- pkg/imgpkg/registry/registry.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/imgpkg/registry/registry.go b/pkg/imgpkg/registry/registry.go index 00d9468eb..9a10033b4 100644 --- a/pkg/imgpkg/registry/registry.go +++ b/pkg/imgpkg/registry/registry.go @@ -199,7 +199,7 @@ func NewSimpleRegistryWithTransport(opts Opts, rTripper http.RoundTripper) (*Sim sessionID := opts.SessionID if sessionID == "" { - sessionID = fmt.Sprint(rand.Intn(9999999999)) + sessionID = fmt.Sprint(rand.Int31()) } baseRoundTripper = NewImgpkgRoundTripper(baseRoundTripper, sessionID)