Skip to content

Commit

Permalink
machine/mc68681.cpp: unambiguous xr68c681 control blocks
Browse files Browse the repository at this point in the history
  • Loading branch information
@angelosa
angelosa committed Sep 26, 2024
1 parent b4d6fa4 commit ea48cc6
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/devices/machine/mc68681.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -724,6 +724,7 @@ void sc28c94_device::write(offs_t offset, uint8_t data)
void xr68c681_device::write(offs_t offset, uint8_t data)
{
if (offset == 0x02) /* CRA */
{
switch (data >> 4)
{
case 0x08: /* set RX extend bit */
Expand Down Expand Up @@ -757,8 +758,9 @@ void xr68c681_device::write(offs_t offset, uint8_t data)
data &= 0x0f;
break;
}

}
else if (offset == 0x0a) /* CRB */
{
switch (data >> 4)
{
case 0x08: /* set RX extend bit */
Expand Down Expand Up @@ -792,6 +794,7 @@ void xr68c681_device::write(offs_t offset, uint8_t data)
data &= 0x0f;
break;
}
}

mc68681_device::write(offset, data); /* pass on 68681 command */
}
Expand Down Expand Up @@ -1097,7 +1100,6 @@ int xr68c681_device::calc_baud(int ch, bool rx, uint8_t data)
{
int baud_rate;


baud_rate = baud_rate_ACR_0[data & 0x0f];

if (ch == 0)
Expand Down

2 comments on commit ea48cc6

@angelosa
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit not sure why we support a device that isn't tested by anything, but I necessarily need to convert all these devices to address maps so may as well make sure my eyes won't introduce a "regression" there ...

@ajrhacker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmackinlay is working on a new DUART emulation, so you should perhaps hold off on this refactoring.

Please sign in to comment.