Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samcoupe_flop.xml: Added 2 working items #11467

Merged
merged 3 commits into from
Nov 2, 2023
Merged

samcoupe_flop.xml: Added 2 working items #11467

merged 3 commits into from
Nov 2, 2023

Conversation

ArcadeShadow
Copy link
Contributor

Rename "Sam Coupe" to "Sam Coupé"

New working software list additions

Rick Dangerous [Spectrum Computing]
Street Fighter 1 [Spectrum Computing]

@ArcadeShadow
samcoupe_flop.xml: Added 2 working itens
ccf19fc 
Rename "Sam Coupe" to "Sam Coupé"

New working software list additions
--------------------------------------------
Rick Dangerous [Spectrum Computing]
Street Fighter 1 [Spectrum Computing]
@ArcadeShadow ArcadeShadow changed the title samcoupe_flop.xml: Added 2 working itens samcoupe_flop.xml: Added 2 working items Aug 6, 2023
cuavas
cuavas requested changes Aug 6, 2023
View reviewed changes
Copy link
Member

@cuavas cuavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to explicitly qualify UTF-8 strings in C++ source code for portability.

@ArcadeShadow
fixed special char in descriptions
f03fc5a 
Changed the "é" character to "\xC3\xA9"
@ArcadeShadow
Copy link
Contributor Author

You need to explicitly qualify UTF-8 strings in C++ source code for portability.

Please, check if the changes made are the way it must be.

ArcadeShadow
ArcadeShadow commented Aug 12, 2023
View reviewed changes
Copy link
Contributor Author

@ArcadeShadow ArcadeShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forced UTF8 encoding

cuavas
cuavas requested changes Aug 23, 2023
View reviewed changes
Copy link
Member

@cuavas cuavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Escaped encoded UTF-8 in strings is unreadable. Why not qualify them as UTF-8 strings as I suggested?

@ArcadeShadow
Forced UTF8 encoding
a2c58c1 
Forced UTF8 encoding without escape code
@ArcadeShadow
Copy link
Contributor Author

Escaped encoded UTF-8 in strings is unreadable. Why not qualify them as UTF-8 strings as I suggested?

Now I think it's fixed like the way it should be.

@cuavas cuavas merged commit deff875 into mamedev:master Nov 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuavas cuavas Awaiting requested review from cuavas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArcadeShadow @cuavas