Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Turkish strings.po (231005_2315) #11602

Merged
merged 9 commits into from
Oct 9, 2023
Merged

Conversation

kadireksi
Copy link
Contributor

No description provided.

Comment on lines 3249 to 3250
msgid "System is Clone of\t%1$s\n"
msgstr ""
msgstr " Sistem \t%1$s'in klonudur\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s a stray space at the beginning of this translation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment on lines 4368 to +4376
#: src/emu/inpttype.ipp:115
msgctxt "input-name"
msgid "High"
msgstr ""
msgstr "Yüksek"

#: src/emu/inpttype.ipp:116
msgctxt "input-name"
msgid "Low"
msgstr ""
msgstr "Düşük"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please confirm that these are the correct translations for “High” and “Low” in the context of a gambling game? (For example high or low card face value.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never played gambling games in Mame (and real life) .
"3 is higher than 2" = "3 2'den yüksek"
"2 is lower than 3" = "2 3'ten düşük"
in this case translation is correct.
We can also call "3 2'den büyüktür" = "3 is bigger than 2".
I can test it later with gambling games(i also have to test all translations because sometimes even the translations are correct they don't fit the used situation)

Comment on lines 5290 to 5313
#: src/emu/inpttype.ipp:840
msgctxt "input-name"
msgid "Mouse X"
msgstr ""
msgstr "Fare x"

#: src/emu/inpttype.ipp:841
msgctxt "input-name"
msgid "Mouse X 2"
msgstr ""
msgstr "Fare x 2"

#: src/emu/inpttype.ipp:842
msgctxt "input-name"
msgid "Mouse X 3"
msgstr ""
msgstr "Fare x 3"

#: src/emu/inpttype.ipp:843
msgctxt "input-name"
msgid "Mouse X 4"
msgstr ""
msgstr "Fare x 4"

#: src/emu/inpttype.ipp:844
msgctxt "input-name"
msgid "Mouse X 5"
msgstr ""
msgstr "Fare x 5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you’ve used lowercase “x” for mouse X axis inputs, but uppercase “X” for other X axis inputs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

firstly wrote wrong case, then copy paste ^^'

Comment on lines 5916 to 5922
#: plugins/cheatfind/init.lua:737
msgid "Slot 1 Value"
msgstr ""
msgstr "Slot 1 ,değeri"

#: plugins/cheatfind/init.lua:737
msgid "Last Slot Value"
msgstr ""
msgstr "Son Slot Değeri"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word “Slot” is used inappropriately in the English UI for the cheat finder plugin, and I don’t want this carried over to translations unnecessarily.

The way the cheat finder works is that it saves the contents of memory, and then scans for values that changed or didn’t change between the saved memory snapshots. Right now, it refers to these saved snapshots of memory as “slots” in English. This is a poor choice of terminology, since it doesn’t describe what they are, and it can cause confusion with what MAME calls slot devices.

Can you use a better term than “slot” in Turkish to refer to these snapshots of memory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, last time i used cheat finder was 2004 when i found the cheats for "Twin Eagle" for Mame 0.81 xD

Comment on lines 6271 to 6273
msgctxt "plugin-inputmacro"
msgid "When held"
msgstr ""
msgstr "basılı tutunca"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have an initial uppercase letter like the other menu items in this plugin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, most of the typo errors are because of resisting to wear near glasses :)

Comment on lines 6365 to +6367
msgctxt "plugin-timer"
msgid "Wall clock"
msgstr ""
msgstr "Duvar saati"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this context, “Wall clock” refers to elapsed real time using an independent clock/time reference. Can you confirm that the Turkish translation is appropriate?

Copy link
Contributor Author

@kadireksi kadireksi Oct 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will compile Mame tomorrow and check all the translations in place.
BTW i want to ask something, on the ui left panel(filters) there is a choice "Source File" but i couldn't find it in the translation file, am i missing something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI translation files are a bit outdated at the moment, they aren’t quite in sync with the application. I need to get it back in sync, but I also need to review the Brazilian Portuguese updates before I can do that. The “Source File” filter was added since the last time I got the UI translation files in sync, so it can’t be localised at the moment. Sorry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's ok.
meanwhile will check in place transilations from time to time to fix any misuses.Thanks.

Comment on lines 2445 to 2446
msgid " %1$d×%2$d origin (%3$d %4$d)"
msgstr ""
msgstr " %1$d×%2$d köken (%3$d %4$d)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is “origin” in the sense of the origin of a coordinate system. From a quick look at Wikipedia, it suggests it may be called “sıfır noktası” or similar in Turkish?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, fixed it as "sıfır noktası"

@cuavas cuavas merged commit 2635515 into mamedev:master Oct 9, 2023
1 check passed
@mascguy
Copy link

mascguy commented Nov 1, 2023

Folks, the following fatal errors occur, for the Turkish translation file:

language/Turkish/strings.po:1563: missing 'msgstr' section
language/Turkish/strings.po:1573: missing 'msgstr' section
language/Turkish/strings.po:3443:26: invalid control sequence
msgmerge: found 3 fatal errors

The errors for lines 1563 and 1573 look legitimate, as there appear to be missing a msgstr for both sections.

These potentially appear to be from a prior commit/PR though? Regardless, needs to be fixed.

As for line 3443, the control sequence does indeed look incorrect. Presumably the string should simply end with \n, rather than \in?

msgstr "WAN\tUygulanmadı\in"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants