Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video/s3virge: refactor #12182

Closed
wants to merge 20 commits into from
Closed

video/s3virge: refactor #12182

wants to merge 20 commits into from

Conversation

angelosa
Copy link
Member

(TBD)

@angelosa
Copy link
Member Author

Opening as PR for checking where I fumbled during the conversion (timer drift?).

@angelosa
Copy link
Member Author

angelosa commented Apr 7, 2024

I don't yet have a well defined goal here, shortening the FIFO queue is challenging, namely because the docs don't exactly define what's a "slot" vs. the actual BitBLT command length. This is important for win2k (which hangs as soon as user starts accessing stuff) and for a couple (minor) corruption bugs still happening in win98 land.
May consider just doing a bare std::function conversion in selected BitBLT places + other misc cleanups and call it for this branch, postponing localized fixes at later date unless something really obvious pops up.

@angelosa angelosa closed this May 2, 2024
@angelosa angelosa deleted the pci_virge-fifo branch May 2, 2024 17:37
@angelosa
Copy link
Member Author

angelosa commented May 2, 2024

Closing this, applied with 3b5e60b , no use having this in WIP and as a feature branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant