Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeDOS 1.3, remove release candidates #12776

Merged
merged 5 commits into from
Sep 29, 2024

Conversation

chungy
Copy link
Contributor

@chungy chungy commented Sep 16, 2024

An alternative pull request to #12765, this one removing software list items.

This pull includes the final FreeDOS 1.3 release, an unofficial minimalist version, and removes all the release candidates from the list. Being that FreeDOS is an open source project with plentiful of mirrors, it is not in danger of losing its development history and does not really needs MAME's help to preserve them.

From the older pull request, on the minimalist version:

I've also added an unofficial 5150-optimized version from https://archive.org/details/free-dos-1.3-8086-minimized. While I'm wary of including an unofficial release too, it is very useful to making FreeDOS usable on the ibm5150 driver, the regular version being much more optimized for the 486/Pentium era of computers. It also only comes in two 360K floppy disks, instead of a dozen 720K disks. The second third commit can easily be omitted if it's not suitable for the MAME software list.

@chungy
Copy link
Contributor Author

chungy commented Sep 16, 2024

I pushed hard disk image definitions here, which are tricky to handle since no such image exists in the upstream distributions.

I'll attach here both the disk images and INP files that can be used to recreate the disk images.

freedos13.zip

Comment on lines 35 to 48
<software name="freedos13">
<description>FreeDOS 1.3</description>
<year>2022</year>
<publisher>The FreeDOS Project</publisher>
<part name="hdd" interface="ide_hdd">
<diskarea name="harddriv">
<disk name="freedos13rc4" sha1="bb81d708746f4e5cfd4207af598cd7691a8e33bf" writeable="yes"/>
<disk name="freedos13" sha1="72eef7bf0ad53b8a240ce05244173df54db923f0" writeable="yes"/>
</diskarea>
</part>
</software>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: FreeDOS 1.3 (at least) has a out-the-box bug around CPU detection (which comes from the vinfo /m calls), so for example it will wrongly goto as 80186 in ct486.
0003
https://gitlab.com/FreeDOS/issue-reporting/-/issues/26

I guess this is worth mentioning in a<notes> line for this HDD entry, giving an hint to the end user about it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could work around it by editing fdauto.bat to always go into the 286/386 routines (this disk image is made for ibm5170, after all), but that'd both require me to make a new inp (install from scratch, then edit), and I'd feel kind of dirty for making a modified OS image.

At least a notes line wouldn't involve either of those...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the notes is easy enough, I think, but could you give me a clue to where in the MAME UI it's supposed to display? I can't find it at all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken, the info usage elements should be displayed in UI.

The notes field is just for notes. We use it mostly for documenting things that are broken with the emulation.

Copy link
Member

@angelosa angelosa Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trouble with info usage is that it doesn't allow for multiline commentary afaik, so long lines will go way after any conventional file width limit. fwiw frontend has no problem in displaying it, it will just provide a scrolling option in the tab:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not even sure it's necessary. It's not really MAME's job to point out all software bugs, and this one doesn't cause FreeDOS to be unusable.

@chungy chungy force-pushed the freedos13_cleanup branch 3 times, most recently from 55d5485 to ea4d3a7 Compare September 16, 2024 16:44
<software name="freedos13rc1">
<description>FreeDOS 1.3 Release Candidate 1 (bootdisk)</description>
<year>2019</year>
<software name="freedos13">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bootdisk is tied with the CDROM release, should be moved in ibm5170_cdrom.xml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bootdisk is tied with the CDROM release, should be moved in ibm5170_cdrom.xml

Agreed :) This was one of my earlier PRs, I'll fix this up now.

These aren't particularly useful releases, and FreeDOS is in no grave
danger of losing their development history by excluding them from MAME
software lists, being an open source project with plentiful of
mirrors.

Removed software list titles (ibm5150.xml, ibm5170.xml, ibm5170_cdrom.xml, ibm5170_hdd.xml)
-------------------------------------------------------------------------------------------
FreeDOS 1.3 Release Candidate 1
FreeDOS 1.3 Release Candidate 2
FreeDOS 1.3 Release Candidate 3
FreeDOS 1.3 Release Candidate 4
New working software list items (ibm5150.xml, ibm5170.xml, ibm5170_cdrom.xml)
-----------------------------------------------------------------------------
FreeDOS 1.3 [FreeDOS Project]
These files are inseparatably attached to the CD-ROM releases, as
their only purpose is to boot the installer on systems that do not
support CD-ROM booting.
This is not an official FreeDOS distribution, but it is a useful one
for the ibm5150 driver, stripping down the operating system into
something reasonable to run on the original IBM PC architecture.

Useful links about what it is:
https://www.youtube.com/watch?v=EOVLlMQs9f8
https://archive.org/details/free-dos-1.3-8086-minimized

New working software list items (ibm5150.xml)
---------------------------------------------
FreeDOS 1.3 8086 Minimized [AkBKukU]
These are just basic installs of the operating system from the
installation media.
@angelosa angelosa merged commit 3bd2fa4 into mamedev:master Sep 29, 2024
3 checks passed
@chungy chungy deleted the freedos13_cleanup branch September 29, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants