hash/bml3_flop.xml: bulk convert all MP-1802 5.25-inch images to DD #12792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
angelosa
commented
Sep 19, 2024
angelosa
commented
- hitachi/bml3.cpp: drop bml3 prefix for all bus slot options;
angelosa
commented
Sep 19, 2024
| @@ -17,7 +17,7 @@ Compatibility flags: | |||
| <sharedfeat name="compatibility" value="5" /> | |||
| <part name="flop1" interface="floppy_5_25"> | |||
| <dataarea name="flop" size="346800"> | |||
| <rom name="hiwriter.d88" size="346800" crc="637f3b94" sha1="0bf7fdb528e03aa2409f386e63e257f5aa013c8f" /> | |||
| <rom name="hiwriter.d88" size="346800" crc="53015bf2" sha1="73cbde8f921203335c1afa68ce4accb5d0be4ce5" /> | |||
There was a problem hiding this comment.
All these images gets interpreted by d88_disk.cpp as QD, which doesn't look the case by looking at the MP-1802 documentation.
|
I added the d88 track check recently in 425573a. I may have made it too strict. |
|
I relaxed d88 check in 26ea918 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.