Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash/ibm5170_cdrom.xml: add Star Trek games #12828

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

chungy
Copy link
Contributor

@chungy chungy commented Sep 29, 2024

New working software list items (ibm5170_cdrom.xml)

Star Trek: 25th Anniversary (Enhanced CD-ROM) [Interplay]
Star Trek: Judgment Rites (Collector's Edition) [Interplay]

<publisher>Interplay</publisher>
<info name="copy_protection" value="Manual required for map" />
<info name="developer" value="Interplay" />
<info name="language" value="English, French, German" />
Copy link
Contributor

@ArcadeShadow ArcadeShadow Sep 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the language info syntax like the others:
<info name="language" value="English/French/German" />
For example, see the "Beneath a Steel Sky (Europe)" set.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the language info syntax like the others: <info name="language" value="English/French/German" /> For example, see the "Beneath a Steel Sky (Europe)" set.

Thanks :)

@angelosa
Copy link
Member

Star Trek: 25th Anniversary (Enhanced CD-ROM) [Interplay]
Star Trek: Judgment Rites (Collector's Edition) [Interplay]

Please give context here: the square brackets are for crediting who dumped it. And I don't think it's necessary to specify Interplay here: it's implicit from the release names.

New working software list items (ibm5170_cdrom.xml)
---------------------------------------------------
Star Trek: 25th Anniversary (Enhanced CD-ROM)
Star Trek: Judgment Rites (Collector's Edition)
@chungy
Copy link
Contributor Author

chungy commented Sep 29, 2024

Please give context here: the square brackets are for crediting who dumped it. And I don't think it's necessary to specify Interplay here: it's implicit from the release names.

These are extracted out of the GOG.com release, so I think it's a bit unknown who dumped it. They match the noted redump.org entries, and I'd call that good enough.

@ajrhacker ajrhacker merged commit c87f8a3 into mamedev:master Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants