hash/thinkpad8xx.xml: Add AIX 4 (not working) #12832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New software list items marked not working ------------------------------------------ thinkpad8xx.xml: IBM AIX 4 [ClawGrip] Also added some metadata to AIX 4.1.5
cuavas
reviewed
Oct 6, 2024
Done, thanks! |
cuavas
reviewed
Oct 8, 2024
hash/thinkpad8xx.xml
Outdated
Comment on lines
17
to
25
| <feature name="form" value="LK2T0241" /> <!-- FORM on internal .Version --> | ||
| <feature name="date" value="970227070036" /> <!-- September 29, 2000, on internal .Version --> | ||
| <diskarea name="cdrom"> | ||
| <disk name="aix_4.1.5_disc_01" sha1="4c49c8190e33c2c7f13a74d7332d384edd6b3042" /> | ||
| </diskarea> | ||
| </part> | ||
| <part name="cdrom2" interface="cdrom"> | ||
| <feature name="part_id" value="AIX 4 Volume 2 of 2" /> | ||
| <feature name="date" value="970331130110" /> <!-- September 30, 2000, on internal .Version --> |
There was a problem hiding this comment.
Are you sure these are supposed to be UNIX timestamps? They don’t make sense interpreted that way. Wouldn’t it be more likely to be 1997-03-31T13:01:10?
There was a problem hiding this comment.
Yes, absolutely. I've fixed it.
hash/thinkpad8xx.xml
Outdated
Comment on lines
39
to
42
| <feature name="part_number" value="40H1045" /> <!-- PN on CD cover --> | ||
| <feature name="part" value="11H6464" /> <!-- PART on internal .Version --> | ||
| <feature name="form" value="Power Desktop" /> <!-- FORM on internal .Version --> | ||
| <feature name="date" value="951031114200" /> <!-- February 20, 2000 --> |
There was a problem hiding this comment.
Same with this – the date doesn’t make sense as a UNIX timestamp, but 1995-10-31T11:42:00 makes sense as a build date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New software list items marked not working
thinkpad8xx.xml: IBM AIX 4 [ClawGrip]
Also added some metadata to AIX 4.1.5