hash/nes.xml: remove dgolf baddump status on verified ROMs #12859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm feeling more confident than before that my 1.4FDS and 1.4TE rebuilds will match original downloads, given all other versions have done so too. I suppose it's still not absolutely guaranteed, but it's vanishingly unlikely. |
cuavas
reviewed
Oct 8, 2024
hash/nes.xml
Outdated
Comment on lines
8532
to
8534
| <notes><![CDATA[ | ||
| An original download should be located to verify and/or update the hash. | ||
| Original 1.4 release ROM was sent as an email attachment, matching this hash. | ||
| ]]></notes> |
hash/nes.xml
Outdated
Comment on lines
8554
to
8556
| <notes><![CDATA[ | ||
| An original download should be located to verify and/or update the hash. | ||
| The released ROM is in the Git repository at /temp/dgolf.nes for tag 1.3 | ||
| ]]></notes> |
There was a problem hiding this comment.
Same, this one isn’t needed either.
hash/nes.xml
Outdated
Comment on lines
8574
to
8576
| <notes><![CDATA[ | ||
| An original download should be located to verify and/or update the hash. | ||
| The released ROM is in the Git repository at /temp/dgolf.nes for tag 1.2 | ||
| ]]></notes> |
hash/nes.xml
Outdated
Comment on lines
8594
to
8596
| <notes><![CDATA[ | ||
| An original download should be located to verify and/or update the hash. | ||
| The released ROM is in the Git repository at /temp/dgolf.nes for tag 1.1 | ||
| ]]></notes> |
hash/nes.xml
Outdated
Comment on lines
8614
to
8616
| <notes><![CDATA[ | ||
| An original download should be located to verify and/or update the hash. | ||
| The released ROM is in the Git repository at /temp/dgolf.nes for tag 1.0 | ||
| ]]></notes> |
Thanks :) |
Versions 1.0-1.3 were included in the source repository (and a rebuild was unnecessary after all), and 1.4 was located by the author and sent via email attachment, matching the rebuild I had done previously. Still unverified with original files: 1.4TE (NES), and 1.4FDS. From Brad Smith, the author, via email: > Sorry, I don't have a history of old builds for it, though you'll > find that the ROM was included in the source tree for 1.0 - 1.3. I > removed it in 1.4. > > However, 1.0-1.2 were essentially beta builds which I don't consider > any of a proper "release".1.3 was the actual version submitted to > the NESDev compo. > > Version 1.4 makes no logical changes from 1.3, just a few tiny C > optimizations that made no difference to the gameplay from 1.3. > > I also made a "tournament edition" variation of 1.4 for speedrunners > who wanted to use the same seed, and a build for the FDS. > > Finally version 1.5 merged the tournament edition menu into a > "secret code" so there was now just one ROM for both. At this time I > updated the FDS version to 1.5, and later created a SNES version > based on 1.5. > > Unfortunately, the C code will compile differently depending on > which version of cc65 was used, though I think I did document the > version used for each version, so check the readme to see what > version it said it used. The differences should be logically > unimportant, but may produce a different binary. Thankfully the > assembly code isn't subject to this problem. > > -- Brad Smith
|
I can confirm that the 1.4TE PRG matches a copy I downloaded back on November 10th, 2019, so the comment about the rebuild being unverified can be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions 1.0-1.3 were included in the source repository (and a rebuild was unnecessary after all), and 1.4 was located by the author and sent via email attachment, matching the rebuild I had done previously.
Still unverified with original files: 1.4TE (NES), and 1.4FDS.
From Brad Smith, the author, via email: