Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ussr/bk: quickload and switchable b&w/color output #12911

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shattered
Copy link
Contributor

No description provided.

@MooglyGuy
Copy link
Contributor

To make the code more informative, I would rename "extra button" to "color toggle button" or something similar, and rename update_monitor to update_monitor_type.

Also, why the rename from screen_update to screen_update_10? Although it's not an override, by convention the function tends not to be changed from screen_update unless there is a reason to do so, and in this case it's the only screen-update function in the driver.

@shattered
Copy link
Contributor Author

extra_button rename makes sense.

bk0011 model has a bit more complex video hardware (two framebuffers, palettes, vblank irq). Some recent releases use mid-screen palette switching, so I'm planning to use a separate screen_update_11 and a scanline timer to implement that.

@MooglyGuy
Copy link
Contributor

At that point, would it make more sense to subclass the driver and simply override the base screen_update entirely?

@shattered
Copy link
Contributor Author

Maybe, but I'd like to get the WIP code out of the door first

@ajrhacker
Copy link
Contributor

I don't understand why there needs to be a hacky extra input in the keyboard device here.

@shattered
Copy link
Contributor Author

Purely for usability -- it's a bit clunky to toggle the configuration bit via UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants