Various namco 2d drivers cleanups, updates #12962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cam900
commented
Nov 11, 2024
cam900
commented
- Various drivers:
- Make some variables constant
- Fix spacing
- Use BIT macro for bit flags
- Suppress side effects in debugger read
- Reduce literal tag usages
- Reduce unnecessary lines
- namco/namco_c123tmap.cpp:
- Use generic gfx layout
- Use reference in delegate
- Fix notes
- namco/namco_c169roz.cpp:
- Use generic gfx layout
- Use reference in delegate
- namco/namcofl.cpp:
- Fix maincpu ROM region size match to memory map
- Fix notes
- namco/namconb1.cpp:
- Split namco NB2 hardware and Point Blank/Gun Bullet driver state
- Reduce preprocessor defines
- Fix typename values
- namco/namcos1.cpp:
- Split quester driver state for reduce optional finders
- Fix typename value for save states
- namco/namcos2.cpp:
- Fix typename consistency
- Simplify gfx decode layout
- namco/namcos2_roz.cpp:
- Use generic gfx layout
- namco/namcos2_sprite.cpp:
- Use device_gfx_interface for gfx decode
- shared/namco_c355spr.cpp:
- Use generic gfx layouts
- Fix notes
- Various drivers: - Make some variables constant - Fix spacing - Use BIT macro for bit flags - Suppress side effects in debugger read - Reduce literal tag usages - Reduce unnecessary lines - namco/namco_c123tmap.cpp: - Use generic gfx layout - Use reference in delegate - Fix notes - namco/namco_c169roz.cpp: - Use generic gfx layout - Use reference in delegate - namco/namcofl.cpp: - Fix maincpu ROM region size match to memory map - Fix notes - namco/namconb1.cpp: - Split namco NB2 hardware and Point Blank/Gun Bullet driver state - Reduce preprocessor defines - Fix typename values - namco/namcos1.cpp: - Split quester driver state for reduce optional finders - Fix typename value for save states - namco/namcos2.cpp: - Fix typename consistency - Simplify gfx decode layout - namco/namcos2_roz.cpp: - Use generic gfx layout - namco/namcos2_sprite.cpp: - Use device_gfx_interface for gfx decode - shared/namco_c355spr.cpp: - Use generic gfx layouts - Fix notes
cuavas
reviewed
Nov 11, 2024
namco/namcos1.cpp: Fix input value for debugger read case namco/namcos2.cpp: Fix boolean testing
cuavas
reviewed
Nov 14, 2024
src/mame/namco/namcos1_m.cpp
Outdated
Comment on lines
1005
to
1050
| switch (m_input_count) | ||
| switch (input_count) | ||
| { | ||
| case 0: | ||
| m_stored_input[0] = m_io_in[0]->read() & 0x1f; | ||
| m_stored_input[1] = (m_io_in[3]->read() & 0x07) << 3; | ||
| stored_input[0] = m_io_in[0]->read() & 0x1f; | ||
| stored_input[1] = (m_io_in[3]->read() & 0x07) << 3; | ||
| break; | ||
|
|
||
| case 3: | ||
| m_stored_input[0] = m_io_in[2]->read() & 0x1f; | ||
| stored_input[0] = m_io_in[2]->read() & 0x1f; | ||
| break; | ||
|
|
||
| case 4: | ||
| m_stored_input[0] = m_io_in[1]->read() & 0x1f; | ||
| m_stored_input[1] = m_io_in[3]->read() & 0x18; | ||
| stored_input[0] = m_io_in[1]->read() & 0x1f; | ||
| stored_input[1] = m_io_in[3]->read() & 0x18; | ||
| break; | ||
|
|
||
| default: | ||
| m_stored_input[0] = 0x1f; | ||
| m_stored_input[1] = 0x1f; | ||
| stored_input[0] = 0x1f; | ||
| stored_input[1] = 0x1f; | ||
| break; | ||
| } |
There was a problem hiding this comment.
You don’t need the local stored_input – you can skip this switch statement entirely if side effects are disabled since the values of the stored inputs aren’t used for calculating the res value in this path of the if (strobe_count > 8).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.