Fix: GFA Lüneburg - set house number correctly (#2946)

* Add Streetchanged request * Fix test case description * fix - Doc issues
mampfes · Oct 30, 2024 · d5b3c0f · d5b3c0f
1 parent 23ef38f
commit d5b3c0f
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 15 deletions.
diff --git a/...components/waste_collection_schedule/waste_collection_schedule/source/gfa_lueneburg_de.py b/...components/waste_collection_schedule/waste_collection_schedule/source/gfa_lueneburg_de.py
@@ -10,7 +10,7 @@
 DESCRIPTION = "Source for GFA Lüneburg."
 URL = "https://www.gfa-lueneburg.de/"
 TEST_CASES = {
-    "Andervenne Am Gallenberg": {
+    "Dahlem Hauptstr. 7": {
         "city": "Dahlem",
         "street": "Hauptstr.",
         "house_number": 7,
@@ -82,8 +82,6 @@ def fetch(self):
         )
         r.raise_for_status()
         r.encoding = "utf-8"
-        with open("test1.html", "w") as f:
-            f.write(r.text)
 
         parser = HiddenInputParser()
         parser.feed(r.text)
@@ -101,16 +99,26 @@ def fetch(self):
         )
         r.raise_for_status()
 
+        args = parser.args
+        args["Ort"] = self._city
+        args["Strasse"] = self._street
+        args["Hausnummer"] = str(self._hnr)
+        args["Method"] = "POST"
+        args["SubmitAction"] = "STREETCHANGED"
+        args["Focus"] = "Strasse"
+        r = session.post(SERVLET, data=args)
+        r.raise_for_status()
+
         args["SubmitAction"] = "forward"
         r = session.post(
             SERVLET,
             data=args,
         )
         r.raise_for_status()
 
-        args[
-            "ApplicationName"
-        ] = "com.athos.kd.lueneburg.WasteDisposalServicesBusinessCase"
+        args["ApplicationName"] = (
+            "com.athos.kd.lueneburg.WasteDisposalServicesBusinessCase"
+        )
         args["SubmitAction"] = "filedownload_ICAL"
         args["IsLastPage"] = "true"
         args["Method"] = "POST"

diff --git a/doc/source/gfa_lueneburg_de.md b/doc/source/gfa_lueneburg_de.md
@@ -1,13 +1,13 @@
-# Abfallwirtschaftsbetrieb Emsland
+# GFA Lüneburg
 
-Support for schedules provided by [Emsland Abfallwirtschaftsbetrieb](https://www.awb-emsland.de/), Germany.
+Support for schedules provided by [GFA Lüneburg](https://www.gfa-lueneburg.de/service/abfuhrkalender.html), Germany.
 
 ## Configuration via configuration.yaml
 
 ```yaml
 waste_collection_schedule:
   sources:
-    - name: awb_emsland_de
+    - name: gfa_lueneburg_de
       args:
         city: CITY
         street: STREET
@@ -17,21 +17,20 @@ waste_collection_schedule:
 ### Configuration Variables
 
 **city**  
-*(string) (required)*
+_(string) (required)_
 
 **street**  
-*(string) (required)*
+_(string) (required)_
 
 **house_number**  
-*(integer) (required)*
-
+_(integer) (required)_
 
 ## Example
 
 ```yaml
 waste_collection_schedule:
   sources:
-    - name: awb_emsland_de
+    - name: gfa_lueneburg_de
       args:
         city: "Dahlem"
         street: "Hauptstr"
@@ -41,7 +40,7 @@ waste_collection_schedule:
 ```yaml
 waste_collection_schedule:
   sources:
-    - name: awb_emsland_de
+    - name: gfa_lueneburg_de
       args:
         city: Wendish Evern
         street: Kückenbrook