Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar Entries Incorrect for City of Port Adelaide Enfield, South Australia #1110

Closed
bbayu123 opened this issue Jul 21, 2023 · 1 comment
Closed
Labels
source defect Defect of a source reported

Comments

@bbayu123
Copy link

bbayu123 commented Jul 21, 2023

Version: 1.41.0
HA Version: core-2023.7.2

The Calendar entries do not match the data on https://www.cityofpae.sa.gov.au/live/waste/bin-collection.

There are 4 dates shown on the City of PAE site. When compared with the HA calendar entries:

  • 2 dates are correct
  • 1 date is listed for the wrong month
  • 1 date is completely missing

Address is redacted in screenshots, but this was tested using an address in the Tuesday Area 1 collection zone.
Update: Also tested with the address listed in the source code under TEST_CASES, which is Tuesday Area 2 - it has the same problem.


Collection schedule for Tuesday Area 1 taken from City of PAE website
image


Calendar entries populated in HA for July and August
image
image


Config.yml entry

waste_collection_schedule:
  sources:
    - name: portenf_sa_gov_au
      args:
        suburb: !secret local_address_suburb
        street: !secret local_address_street
        house_number: !secret local_address_house_num
@5ila5
Copy link
Collaborator

5ila5 commented Nov 18, 2023

sorry for the long time it took to address this issue it should be fixed by #1427 but it may lead to errors in December as dates are extracted from the calendar and i currently do not know it it will be displayed if there are dates from December of one year and January of another.

Fix will be part of release 1.44.0 or is available as master (git) version now (HACS: 3-dot menu -> re-download -> change version to master)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source defect Defect of a source reported
Projects
None yet
Development

No branches or pull requests

2 participants