Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted Christmas Collections - Wokingham UK #3320

Closed
6 of 7 tasks
dpatterson87 opened this issue Dec 28, 2024 · 8 comments · Fixed by #3324
Closed
6 of 7 tasks

Adjusted Christmas Collections - Wokingham UK #3320

dpatterson87 opened this issue Dec 28, 2024 · 8 comments · Fixed by #3324

Comments

@dpatterson87
Copy link

I Have A Problem With:

A specific source

What's Your Problem

The dates returned by the integration do not include temporary adjusted dates for the Christmas holiday/New Year period.
These are provided on the source website.

example source UK - Wokingham Borough Council

A previous similar fix #1526 suggests the holiday date adjustments are expected. (Although this is different source)

Source (if relevant)

Wokingham_Borough_Council_UK

Logs

No response

Relevant Configuration

No response

Checklist Source Error

  • Use the example parameters for your source (often available in the documentation) (don't forget to restart Home Assistant after changing the configuration)
  • Checked that the website of your service provider is still working
  • Tested my attributes on the service provider website (if possible)
  • I have tested with the latest version of the integration (master) (for HACS in the 3 dot menu of the integration click on "Redownload" and choose master as version)

Checklist Sensor Error

  • Checked in the Home Assistant Calendar tab if the event names match the types names (if types argument is used)

Required

  • I have searched past (closed AND opened) issues to see if this bug has already been reported, and it hasn't been.
  • I understand that people give their precious time for free, and thus I've done my very best to make this problem as easy as possible to investigate.
@dt215git
Copy link
Contributor

Are you wanting just the dates displayed in the top half of this image, or both the changed and regular collection dates?

image

@dpatterson87
Copy link
Author

dpatterson87 commented Dec 29, 2024

Hi @dt215git,
I’d think just the changed dates as these “override” the related regular collection dates during that period. This should then accurately show the actual collection days.

That said, I’m not sure how the underlying calendar dataset reflects these changes.

Thanks

@5ila5
Copy link
Collaborator

5ila5 commented Dec 29, 2024

Fixed in #3324

This will be part of the next release or is available now as master (git) version

install master/git: Developer tools -> actions -> select update: Install update -> click Coose entity and select WCS -> select version and type master in the input field -> run the action -> restart HA

Older versions of HACS:

install master with HACS version < 2.0: (3-dot menu -> redownload -> change version to master -> fully restart HA (this will increase update cycle by a lot)

@dpatterson87
Copy link
Author

Thanks @5ila5 @dt215git
Just installed the master version, and while the calendar is correctly displaying the holiday dates, the default card component is not.

IMG_1741
IMG_1742
IMG_1743

When reverting to the current release version 2.5, the card component is correctly displayed.

IMG_1744

@dt215git
Copy link
Contributor

What entities/states are being used by the card component?
It may be the additional "(Christmas Schedule)" text is the issue.

@dpatterson87
Copy link
Author

What entities/states are being used by the card component? It may be the additional "(Christmas Schedule)" text is the issue.

It’s a single sensor/entity with “upcoming” details format. I include all filter types (since blank doesn’t return all), and the Christmas Schedule types aren’t included.

@dt215git
Copy link
Contributor

Just added a Wokingam source to my HA instance using one of the test cases from the script, and the upcoming sensor seems to work for me.

image

image

@dpatterson87
Copy link
Author

@dt215git adding a brand new sensor solved the issue for me - I’m new to HA so will assume it was user error somewhere.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants