Reorder innerwest_nsw_gov_au APIs to work around duplicate data #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorder Inner West Council possible APIs to attempt old Leichhardt Council before attempting old Marrickville Council. A single suburb is duplicated between the 3 lists: "Leichhardt" appears in both Leichhardt and Marrickville API endpoints. Only a single street in Leichhardt is listed by the Marrickville endpoint, and that with only a single property; this is likely bad data. This is not a lasting fix, as it doesn't protect against future duplicates, but there are thousands of properties in "true" Leichhardt, and only one in "false" Leichhardt, so at least this reordering fixes for most people.
|
Thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorder Inner West Council possible APIs to attempt old Leichhardt Council before attempting old Marrickville Council.
A single suburb is duplicated between the 3 lists: "Leichhardt" appears in both Leichhardt and Marrickville API endpoints. Only a single street in Leichhardt is listed by the Marrickville endpoint, and that with only a single property; this is likely bad data.
This is not a lasting fix, as it doesn't protect against future duplicates, but there are thousands of properties in "true" Leichhardt, and only one in "false" Leichhardt, so at least this reordering fixes for most people.