Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Republic Services #1348

Merged
merged 4 commits into from
Oct 22, 2023
Merged

Update: Republic Services #1348

merged 4 commits into from
Oct 22, 2023

Conversation

dt215git
Copy link
Contributor

Updated to include "Yard Waste" as a separate category, as per request in #1238.
New method arg implemented so users can choose the new categorisation if they want it. If no arg is provided it returns the same categories as before, so shouldn't break existing configs.
Contract Collection and No Method arg test cases below illustrate the difference.

Testing source republicservices_com ...
  found 1 entries for Scott Country Clerk
    2023-10-26 : Solid Waste [mdi:trash-can]
  found 1 entries for Branch County Clerk
    2023-10-23 : Solid Waste [mdi:trash-can]
  found 7 entries for Contract Collection
    2023-10-24 : Yard Waste [mdi:leaf]
    2023-10-31 : Recycle [mdi:recycle]
    2023-11-14 : Recycle [mdi:recycle]
    2023-11-28 : Recycle [mdi:recycle]
    2023-12-12 : Recycle [mdi:recycle]
    2023-12-26 : Recycle [mdi:recycle]
    2023-10-24 : Solid Waste [mdi:trash-can]
  found 1 entries for Residential Collection
    2023-10-26 : Solid Waste [mdi:trash-can]
  found 7 entries for No Method arg
    2023-10-24 : Recycle [mdi:leaf]
    2023-10-31 : Recycle [mdi:recycle]
    2023-11-14 : Recycle [mdi:recycle]
    2023-11-28 : Recycle [mdi:recycle]
    2023-12-12 : Recycle [mdi:recycle]
    2023-12-26 : Recycle [mdi:recycle]

@5ila5 5ila5 merged commit db9298e into mampfes:master Oct 22, 2023
1 check passed
@dt215git dt215git deleted the repserv_yardwaste branch October 22, 2023 16:16
@dai80027
Copy link

I'm seeing this when I try to add the "method" argument:

2023-10-24 21:18:49.987 ERROR (MainThread) [homeassistant.setup] Error during setup of component waste_collection_schedule
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/setup.py", line 288, in _async_setup_component
result = await task
^^^^^^^^^^
File "/config/custom_components/waste_collection_schedule/init.py", line 109, in async_setup
api.add_source_shell(
File "/config/custom_components/waste_collection_schedule/init.py", line 202, in add_source_shell
SourceShell.create(
File "/config/custom_components/waste_collection_schedule/waste_collection_schedule/source_shell.py", line 196, in create
source = source_module.Source(**source_args) # type: ignore
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: Source.init() got an unexpected keyword argument 'method'

Am I doing something wrong? Thanks!

@dt215git
Copy link
Contributor Author

The update has only just been merged, you probably need to pull down the latest version to your local HA instance.
HACS, WCS, 3-dots (top right), Redownload, select master in the Select Version dropdown.

@dai80027
Copy link

Thanks for the response. I did as you suggested (2x, just to be sure) but I'm still getting the same error message.

@dt215git
Copy link
Contributor Author

Did you reboot to force it to reload the componenet?

When using the method 2 test case, I get this:
image

You could also check the republicservices_com.py file on your local HA instance to make sure it's contains the updated script.

@dai80027
Copy link

dai80027 commented Oct 26, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants