Adding dedicated mijnafvalwijzer nl #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
5ila5
requested changes
Dec 24, 2024
..._components/waste_collection_schedule/waste_collection_schedule/source/mijnafvalwijzer_nl.py
Outdated
Show resolved
Hide resolved
..._components/waste_collection_schedule/waste_collection_schedule/source/mijnafvalwijzer_nl.py
Outdated
Show resolved
Hide resolved
..._components/waste_collection_schedule/waste_collection_schedule/source/mijnafvalwijzer_nl.py
Outdated
Show resolved
Hide resolved
..._components/waste_collection_schedule/waste_collection_schedule/source/mijnafvalwijzer_nl.py
Outdated
Show resolved
Hide resolved
..._components/waste_collection_schedule/waste_collection_schedule/source/mijnafvalwijzer_nl.py
Outdated
Show resolved
Hide resolved
|
Hi @5ila5 , just committed with requested changes |
5ila5
approved these changes
Dec 28, 2024
|
Thanks for your contribution |
|
Thanks for the review and good suggestions. When will it be released to HACS? |
|
I think I will release a new version soon. But I'd like to address some more issues for now. You can install the master/git/development version with HACS install master/git: Developer tools -> actions -> select Older versions of HACS:install master with HACS version < 2.0: (3-dot menu -> redownload -> change version to master -> fully restart HA (this will increase update cycle by a lot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mijnafvalwijzer nl does not offer ics support anymore: #3105 (comment)
Therefore I added support via dedicated source (parsing html)