Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Royal Borough Of Greenwich #3278

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Added support for Royal Borough Of Greenwich #3278

merged 3 commits into from
Dec 27, 2024

Conversation

timocov
Copy link
Contributor

@timocov timocov commented Dec 25, 2024

Fixes #3277

$ python3 test_sources.py -i -l -s royalgreenwich_gov_uk
Testing source royalgreenwich_gov_uk ...
  found 25 entries for address
    2024-12-31 : recycling [mdi:recycle]
    2025-01-07 : recycling [mdi:recycle]
    2025-01-14 : recycling [mdi:recycle]
    2025-01-21 : recycling [mdi:recycle]
    2025-01-28 : recycling [mdi:recycle]
    2025-02-04 : recycling [mdi:recycle]
    2025-02-11 : recycling [mdi:recycle]
    2025-02-18 : recycling [mdi:recycle]
    2025-02-25 : recycling [mdi:recycle]
    2025-03-04 : recycling [mdi:recycle]
    2024-12-31 : garden [mdi:leaf]
    2025-01-07 : garden [mdi:leaf]
    2025-01-14 : garden [mdi:leaf]
    2025-01-21 : garden [mdi:leaf]
    2025-01-28 : garden [mdi:leaf]
    2025-02-04 : garden [mdi:leaf]
    2025-02-11 : garden [mdi:leaf]
    2025-02-18 : garden [mdi:leaf]
    2025-02-25 : garden [mdi:leaf]
    2025-03-04 : garden [mdi:leaf]
    2024-12-31 : food [mdi:food-apple]
    2025-01-14 : food [mdi:food-apple]
    2025-01-28 : food [mdi:food-apple]
    2025-02-11 : food [mdi:food-apple]
    2025-02-25 : food [mdi:food-apple]
  found 25 entries for houseNumber
    2024-12-25 : recycling [mdi:recycle]
    2025-01-01 : recycling [mdi:recycle]
    2025-01-08 : recycling [mdi:recycle]
    2025-01-15 : recycling [mdi:recycle]
    2025-01-22 : recycling [mdi:recycle]
    2025-01-29 : recycling [mdi:recycle]
    2025-02-05 : recycling [mdi:recycle]
    2025-02-12 : recycling [mdi:recycle]
    2025-02-19 : recycling [mdi:recycle]
    2025-02-26 : recycling [mdi:recycle]
    2024-12-25 : garden [mdi:leaf]
    2025-01-01 : garden [mdi:leaf]
    2025-01-08 : garden [mdi:leaf]
    2025-01-15 : garden [mdi:leaf]
    2025-01-22 : garden [mdi:leaf]
    2025-01-29 : garden [mdi:leaf]
    2025-02-05 : garden [mdi:leaf]
    2025-02-12 : garden [mdi:leaf]
    2025-02-19 : garden [mdi:leaf]
    2025-02-26 : garden [mdi:leaf]
    2025-01-01 : food [mdi:food-apple]
    2025-01-15 : food [mdi:food-apple]
    2025-01-29 : food [mdi:food-apple]
    2025-02-12 : food [mdi:food-apple]
    2025-02-26 : food [mdi:food-apple]
  found 25 entries for alternativeWeek
    2024-12-25 : recycling [mdi:recycle]
    2025-01-01 : recycling [mdi:recycle]
    2025-01-08 : recycling [mdi:recycle]
    2025-01-15 : recycling [mdi:recycle]
    2025-01-22 : recycling [mdi:recycle]
    2025-01-29 : recycling [mdi:recycle]
    2025-02-05 : recycling [mdi:recycle]
    2025-02-12 : recycling [mdi:recycle]
    2025-02-19 : recycling [mdi:recycle]
    2025-02-26 : recycling [mdi:recycle]
    2024-12-25 : garden [mdi:leaf]
    2025-01-01 : garden [mdi:leaf]
    2025-01-08 : garden [mdi:leaf]
    2025-01-15 : garden [mdi:leaf]
    2025-01-22 : garden [mdi:leaf]
    2025-01-29 : garden [mdi:leaf]
    2025-02-05 : garden [mdi:leaf]
    2025-02-12 : garden [mdi:leaf]
    2025-02-19 : garden [mdi:leaf]
    2025-02-26 : garden [mdi:leaf]
    2024-12-25 : food [mdi:food-apple]
    2025-01-08 : food [mdi:food-apple]
    2025-01-22 : food [mdi:food-apple]
    2025-02-05 : food [mdi:food-apple]
    2025-02-19 : food [mdi:food-apple]

@timocov timocov force-pushed the royalgreenwich_gov_uk branch from c645231 to 0cd4bb0 Compare December 25, 2024 12:11
@timocov timocov force-pushed the royalgreenwich_gov_uk branch from 0cd4bb0 to c3b1c92 Compare December 26, 2024 23:42
@5ila5 5ila5 merged commit 1956979 into mampfes:master Dec 27, 2024
2 checks passed
@5ila5 5ila5 mentioned this pull request Dec 27, 2024
Closed
@5ila5
Copy link
Collaborator

5ila5 commented Dec 27, 2024

Thanks for your contribution

I did some reformatting (.pre-commit-config.yaml) and fixed the type hint for _get_black_top_bin_next_collection_date (from datetime.datetime to datetime.date)

and added a check in _find_address:

    if not self._post_code:
          raise SourceArgumentRequired(
              "post_code", "postcode is required if address is not provided"
          )

@timocov timocov deleted the royalgreenwich_gov_uk branch December 27, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5ila5 5ila5 5ila5 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Source Request]: Royal Borough of Greenwich
2 participants
@timocov @5ila5