Added support for OLO, Slovakia suource #3283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ila5
requested changes
Dec 26, 2024
Comment on lines
+45
to
+50
| PARAM_TRANSLATIONS = { # Optional dict to translate the arguments, will be shown in the GUI configuration form as placeholder text | ||
| "en": { | ||
| "street": "Enter street name", | ||
| "registrationNumber": "Enter registration number" | ||
| } | ||
| } |
There was a problem hiding this comment.
please remove enter from the string
Comment on lines
+34
to
+36
| HOW_TO_GET_ARGUMENTS_DESCRIPTION = { # Optional dictionary to describe how to get the arguments, will be shown in the GUI configuration form above the input fields, does not need to be translated in all languages | ||
| "en": "HOW TO GET ARGUMENTS DESCRIPTION" | ||
| } |
There was a problem hiding this comment.
Either fill in correct information or remove this Variable. This placeholder text would be shown in the configuration GUI at the moment
| headers = { | ||
| "Content-Type": "application/json", | ||
| "Accept": "application/json", | ||
| "authorization": "Bearer ae84ae0982c2162a81eb253765ceaa8593abd9105c71954cf5c9620b0178cbb6" |
There was a problem hiding this comment.
Is there another way to get this header, I don't like hard coding a Bearer token
| @@ -0,0 +1,37 @@ | |||
| # fcc Environment (VYLOŽ SMETI APP) | |||
There was a problem hiding this comment.
Headline copy-paste leftovers?
Comment on lines
+16
to
+19
| ### Configuration Variables | ||
|
|
||
| **street** | ||
| *(String) (required)* |
| sources: | ||
| - name: olo_sk | ||
| args: | ||
| street: Jantarova 47 |
Comment on lines
+31
to
+37
| ```yaml | ||
| waste_collection_schedule: | ||
| sources: | ||
| - name: olo_sk | ||
| args: | ||
| city: Jasovska 8 | ||
| ``` |
There was a problem hiding this comment.
city is not a valid argument
|
Sorry. This PR was created by mistake on unfinished code. I'll be back with a new one in few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.