Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to use other fields than summary in ical source for event title #663

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

splattner
Copy link
Contributor

@splattner splattner commented Feb 5, 2023

My city uses the Location field in the ical calendar to spererate between different areas while having the same summary. So I need to use the location for distinction

@splattner splattner force-pushed the ics_allow_combined_titles branch 2 times, most recently from 1f3a7d5 to 4809837 Compare February 5, 2023 18:45
@mampfes
Copy link
Owner

mampfes commented Feb 7, 2023

Interesting enhancement! Instead of specifying title and separator, I would prefer to specify a format string like the value_template in the sensor configuration.

Example:

  value_template: '{{summary}} {{location}}'

Do you think this is feasible?

@splattner
Copy link
Contributor Author

I like this idea, let me think a bit more and try to implement it.

@splattner splattner force-pushed the ics_allow_combined_titles branch from 4809837 to 4c41b25 Compare March 27, 2023 14:37
@splattner
Copy link
Contributor Author

Alright, I finally found some time to implement this using template. What do you thing?

@splattner splattner force-pushed the ics_allow_combined_titles branch from 4c41b25 to ebc05e2 Compare April 3, 2023 10:28
@5ila5 5ila5 requested a review from mampfes April 5, 2023 11:15
@splattner
Copy link
Contributor Author

is there anything I can help or change to get this merged?

@splattner
Copy link
Contributor Author

@mampfes What's your opinion on this?

@splattner
Copy link
Contributor Author

Anything I can do to get this merged? Or no interest?

@mampfes
Copy link
Owner

mampfes commented Oct 22, 2023

Anything I can do to get this merged? Or no interest?

Oh, sorry I missed that! Thanks for your contribution. LGTM
@5ila5 Do want to merge it?

@5ila5
Copy link
Collaborator

5ila5 commented Oct 24, 2023

Looks good I added jinja2 to requirements.txt and fixed a spelling error in the ICS.md file

Thanks for your contribution

@5ila5 5ila5 merged commit 9be0bc9 into mampfes:master Oct 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants