Skip to content

Commit

Permalink
Use relative paths for compat tests
Browse files Browse the repository at this point in the history
The absolute paths were breaking some Azure conda-forge runners because
abspath was prefixing the path with `$SRC_DIR` which did not get
expanded on linux.
  • Loading branch information
IvoDD committed Oct 16, 2024
1 parent afe9094 commit d9ec089
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion python/tests/compat/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,9 @@ def assert_read(self, sym : str, df) -> None:
def old_venv(request):
version = request.param
path = os.path.join("venvs", version)
requirements_file = os.path.abspath(os.path.join("tests", "compat", f"requirements-{version}.txt"))
# The requirements_file needs to be relative to the [path] we use for the venv.
# Absolute paths break some Azure CI runners on conda forge
requirements_file = os.path.join("..", "..", "tests", "compat", f"requirements-{version}.txt")
with Venv(path, requirements_file, version) as old_venv:
yield old_venv

Expand Down

0 comments on commit d9ec089

Please sign in to comment.