Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Out of bounds checks for LibraryPath #1829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Out of bounds checks for LibraryPath #1829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cpp/arcticdb/storage/library_path.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ class LibraryPathImpl {
return std::move(a) + delim + fmt::format("{}", b);
};

util::check(rg.size() > 0, "Cannot have an empty LibraryPath");
return std::accumulate(std::next(rg.begin()), rg.end(), fmt::format("{}", rg[0]), delim_fold);
}

Expand Down Expand Up @@ -159,7 +160,7 @@ template<class StringViewable=DefaultStringViewable>
inline bool operator==(const LibraryPathImpl<StringViewable> &l, const LibraryPathImpl<StringViewable> &r) {
auto l_rg = l.as_range();
auto r_rg = r.as_range();
return l.hash() == r.hash() && std::equal(l_rg.begin(), l_rg.end(), r_rg.begin());
return l.hash() == r.hash() && std::equal(l_rg.begin(), l_rg.end(), r_rg.begin(), r_rg.end());
}

using LibraryPath = LibraryPathImpl<DefaultStringViewable>;
Expand Down
Loading