Compat tests 451rc #1912
Merged
Compat tests 451rc #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new compatibility tests are in `tests/compat`. This includes the following: - `old_venv` fixture which allows executing some arctic commands frow within a custom venv. - 2 compatibility tests. One of which showcases an issue with modifying library options of old environments. - Tweak to the Build and Test workflow to run the compat tests only on newer python versions
Previously modifying a library option with a new version (>=v3.0.0) would break old libraries (<v3.0.0) This was because of the storage overrides introduced in v3.0.0. This change moves the logic to modify a library option to C++ and it does the protobuf modification without applying a storage override. This makes storage overrides work well with both old libraries (as demonstrated by now passing compatibility tests) and with new libraries (as confirmed by test_arctic_library_management.py)
- Exposes a `read_unaltered_lib_cfg` method for the `LibraryTool` - Uses it in compatibility modification test to verify that we only change the new fields
When destructing the mongo storage it was possible to destruct the api instance before destructing the pool. Moved the instance from the `MongoStorage` to the `MongoClient` to be kept as a guard around the `mongocxx::pool`. `MongoStorage` didn't need any sensitive mongocxx objects. We also disable mongo tests for 4.5.0 as it contains the problematic segfault.
IvoDD
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
poodlewars
approved these changes
Oct 14, 2024
There have been some mono issues with ubuntu-latest, so we reverted to ubuntu-22.04 for now. The cibw-docker-image workflow was not updated because updating it causes the rebuilt of the manylinux docker image which fails because of CentOS 7 being EOL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1862 to 4.5.1rc
Reference Issues/PRs
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...