Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip lmdb compat tests for versions <= 4.5.0 #1923

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Skip lmdb compat tests for versions <= 4.5.0 #1923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions python/tests/compat/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
MONGO_TESTS_MARK,
VENV_COMPAT_TESTS_MARK,
)
from packaging.version import Version

logger = logging.getLogger("Compatibility tests")

Expand Down Expand Up @@ -173,9 +174,10 @@ def arctic_uri(request):

@pytest.fixture()
def old_venv_and_arctic_uri(old_venv, arctic_uri):
if old_venv.version == "1.6.2" and arctic_uri.startswith("mongo"):
pytest.skip("Mongo storage backend is not supported on 1.6.2")
if old_venv.version == "4.5.0" and arctic_uri.startswith("mongo"):
# TODO: Replace 4.5.0 with 4.5.1 when it is released and re-enable mongo.
pytest.skip("Mongo storage backend has a desctruction bug present in 4.5.0, which can cause flaky segfaults.")
# TODO: Replace 4.5.0 with 4.5.1 when it is released to re-enable both mongo and lmdb.
if Version(old_venv.version) <= Version("4.5.0") and arctic_uri.startswith("mongo"):
pytest.skip("Mongo storage backend has a desctruction bug present until 4.5.0, which can cause flaky segfaults.")
if Version(old_venv.version) <= Version("4.5.0") and arctic_uri.startswith("lmdb"):
pytest.skip("LMDB storage backend has a desctruction bug present until 4.5.0, which can cause flaky segfaults.")

return old_venv, arctic_uri
Loading