use os.path.normpath to remove the trailing / of project path #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dir-locals-find-file will return project directory ending with /, which make os.path.basename to return empty string, so I add os.path.normpath to remove the trailing /.
|
Thanks for the patch The correctness of the project_path path is too important for lsp-bridge. If dir-locals-find-file returns an incorrect value, I think it should be filtered on the elisp side and should not be processed on the python side. |
|
ok, let me do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dir-locals-find-file will return project directory ending with /, which make os.path.basename to return empty string, so I add os.path.normpath to remove the trailing /.