Allow users to specify a custom ghidrathon.save path via an environment variable #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fariss
commented
Apr 5, 2024
mike-hunhoff
requested changes
Apr 9, 2024
There was a problem hiding this comment.
Thanks @s-ff , nice work! I've left comments for your review. Please let me know if you have any questions.
|
@s-ff looks like lints are failing, please see https://github.com/mandiant/Ghidrathon/blob/main/doc/contributing.md for more information on running lints locally. |
Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
fariss
commented
Apr 11, 2024
mike-hunhoff
requested changes
Apr 15, 2024
To make sure that Ghidrathon plugin aligns with configure_ghidrathon.py we need to make sure that the GHIDRATHON_SAVE_PATH is never set to "".
The following commit fixes incorrect login in the previous commit. Please refer to the explination below: if GHIDRATHON_SAVE_PATH is set to any value (other than None or ""), check if it exists and is a directory. elif GHIDRATHON_SAVE_PATH is an empty string, report an invalid directory to avoid confusion. else GHIDRATHON_SAVE_PATH is not, use default install path.
mike-hunhoff
requested changes
Apr 25, 2024
There was a problem hiding this comment.
Thanks @s-ff , we're almost ready merge. I've left two comments for you to address.
src/main/java/ghidrathon/interpreter/GhidrathonInterpreter.java
Outdated
Show resolved
Hide resolved
Added log messages to indicate whether the file path was read from the environment variable or the default path was used.
mike-hunhoff
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #98.