[Fix] 배너 링크 / 예약 페이지 링크 Pascal Case로 변경 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JuneParkCode
commented
Oct 6, 2023
JuneParkCode
commented
- [todo] 링크 수정 #233
- 배너 링크 변경
- 배너에 이미지 없는 경우 이미지 출력 안하도록 변경
- 배너 모바일 css (간격) 일부 수정
- 배너 클릭시 새탭으로 이동하도록 변경
- 내부 경로는 현재 탭에서 이동
- reservation -> Reservation (page)
- footer 로고 모바일 중앙 정렬 안되는 문제 해결
- 링크 새탭 처리 - 배너 모바일 환경 ml 변경 - 배너 이미지 없는 경우에도 받도록 처리
jinaji
approved these changes
Oct 6, 2023
falconlee236
reviewed
Oct 6, 2023
| <Link href="/Mentorings" onClick={onClose}> | ||
| <p className="sidebar-text sidebar-text-btn">멘토링</p> | ||
| </Link> | ||
| {!!uid && ( |
There was a problem hiding this comment.
이게 로그인 안하면 멘토링 버튼이 안뜨게 하는 기능 추가하신것 맞죠?
PR에 관련 내용이 없어서 한참 들어다 봤네요
There was a problem hiding this comment.
아 넵 맞습니다. PR에 로그인 관련 내용을 뺴먹었네요 ㅋㅋ..
falconlee236
approved these changes
Oct 6, 2023
Closed
2 tasks
|
# Conflicts: # 42manito/src/pages/Mentorings/index.tsx
obvoso
pushed a commit
to obvoso/42manito-front
that referenced
this pull request
Oct 27, 2023
* [fix]: 배너 수정 - 링크 새탭 처리 - 배너 모바일 환경 ml 변경 - 배너 이미지 없는 경우에도 받도록 처리 * [fix]: 상단 멘토링 탭 로그인 상태 반영 * [fix]: reservation -> Reservation * [fix]: footer 42 manito 간격 모바일 중앙화 * [fix]: Mentorings 배너 링크 수정 * [fix]: 외부 사이트 경로일 경우에만 새탭으로 열도록 변경 * [fix]: profile Update hashtag.length > 1 적용 * [fix]: 409 alert 핸들링 제거
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.