Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize pydantic v2 #162

Merged
merged 39 commits into from
Jul 24, 2023
Merged

Finalize pydantic v2 #162

merged 39 commits into from
Jul 24, 2023

Conversation

mansenfranzen
Copy link
Owner

@mansenfranzen mansenfranzen commented Jul 22, 2023

Current docs build based on v2: here

There is still some work to do until the release for v2. Following points have to be done:

  • Fix failing tests for python 3.7/3.8
  • Fix failing sphinx build test
  • Check entire documentation for pydantic v1 incompatibilities
    • Remove obsolete config options from rst in examples
    • Adjust to changed naming conventions like root validator -> model validator
  • Document changed behavior from v1 -> v2 regarding autodoc_pydantic
  • Update changelog
  • Remove compatibility layer from v1 versions in testing modules
  • Fix linting issues
  • Provide release candidate for testing
  • Add new contributors

@awoimbee & @PriOliveira feel free to review or to provide any other code contributions.

@mansenfranzen mansenfranzen temporarily deployed to ci July 22, 2023 14:58 — with GitHub Actions Inactive
@mansenfranzen mansenfranzen temporarily deployed to ci July 22, 2023 14:58 — with GitHub Actions Inactive
@mansenfranzen mansenfranzen self-assigned this Jul 22, 2023
@mansenfranzen mansenfranzen added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Jul 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main-2.x@4af0249). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main-2.x     #162   +/-   ##
===========================================
  Coverage            ?   94.39%           
===========================================
  Files               ?       12           
  Lines               ?     1052           
  Branches            ?        0           
===========================================
  Hits                ?      993           
  Misses              ?       59           
  Partials            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mansenfranzen mansenfranzen temporarily deployed to ci July 23, 2023 20:21 — with GitHub Actions Inactive
@mansenfranzen mansenfranzen temporarily deployed to ci July 23, 2023 20:21 — with GitHub Actions Inactive
docs: add awoimbee as a contributor for review, userTesting, and 2 more
@mansenfranzen mansenfranzen temporarily deployed to ci July 24, 2023 19:50 — with GitHub Actions Inactive
@mansenfranzen mansenfranzen temporarily deployed to ci July 24, 2023 19:50 — with GitHub Actions Inactive
@mansenfranzen mansenfranzen temporarily deployed to ci July 24, 2023 19:50 — with GitHub Actions Inactive
@mansenfranzen mansenfranzen temporarily deployed to ci July 24, 2023 19:50 — with GitHub Actions Inactive
Repository owner deleted a comment from allcontributors bot Jul 24, 2023
Repository owner deleted a comment from allcontributors bot Jul 24, 2023
Repository owner deleted a comment from allcontributors bot Jul 24, 2023
Repository owner deleted a comment from allcontributors bot Jul 24, 2023
@mansenfranzen
Copy link
Owner Author

@all-contributors please add @PriOliveira for review, userTesting

@allcontributors
Copy link
Contributor

@mansenfranzen

I've put up a pull request to add @PriOliveira! 🎉

@mansenfranzen mansenfranzen temporarily deployed to ci July 24, 2023 20:01 — with GitHub Actions Inactive
@mansenfranzen mansenfranzen temporarily deployed to ci July 24, 2023 20:01 — with GitHub Actions Inactive
@mansenfranzen mansenfranzen temporarily deployed to ci July 24, 2023 20:01 — with GitHub Actions Inactive
@mansenfranzen mansenfranzen temporarily deployed to ci July 24, 2023 20:01 — with GitHub Actions Inactive
@mansenfranzen mansenfranzen temporarily deployed to ci July 24, 2023 20:02 — with GitHub Actions Inactive
@mansenfranzen mansenfranzen temporarily deployed to ci July 24, 2023 20:02 — with GitHub Actions Inactive
@mansenfranzen mansenfranzen temporarily deployed to ci July 24, 2023 20:02 — with GitHub Actions Inactive
@mansenfranzen mansenfranzen temporarily deployed to ci July 24, 2023 20:02 — with GitHub Actions Inactive
@mansenfranzen mansenfranzen merged commit b769dca into main-2.x Jul 24, 2023
11 checks passed
@mansenfranzen mansenfranzen deleted the finalize_pydantic_v2 branch July 24, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants