-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespace package fix #177
Namespace package fix #177
Conversation
…`ModuleNotFoundError`` exception in some environments. This should be a namespace package per `PEP 420 <https://peps.python.org/pep-0420/>`__ without ``__init_.py`` to match with other extensions.
…nx.testing.path`` module that is being deprecated for forward-compatibility with newer Sphinx versions.
072678e
to
dab7018
Compare
Can confirm that this PR works also in the related issue re documentation:
|
I believe it should be merged and a new release distributed if possible! You're doing amazing work and it's very appreciated |
Thanks for the PR! Sorry for taking so long but I will soon merge it once the CI pipeline succeeds. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 0.00% 95.84% +95.84%
==========================================
Files 12 12
Lines 1035 1035
==========================================
+ Hits 0 992 +992
+ Misses 1035 43 -992 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing the PR and testing it!
Fix #176
Also update test conftest to use pathlib for forward-compatibility with newer Sphinx without deprecation warnings, etc.