Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace package fix #177

Merged
merged 6 commits into from
Dec 27, 2023

Conversation

devmonkey22
Copy link
Contributor

Fix #176

Also update test conftest to use pathlib for forward-compatibility with newer Sphinx without deprecation warnings, etc.

…`ModuleNotFoundError`` exception in some environments. This should be a namespace package per `PEP 420 <https://peps.python.org/pep-0420/>`__ without ``__init_.py`` to match with other extensions.
…nx.testing.path`` module that is being deprecated for forward-compatibility with newer Sphinx versions.
@daquinteroflex
Copy link

Can confirm that this PR works also in the related issue re documentation:

 poetry install -E dev
Installing dependencies from lock file

Package operations: 20 installs, 0 updates, 0 removals

  • Installing distlib (0.3.7)
  • Installing filelock (3.12.2)
  • Installing platformdirs (4.0.0)
  • Installing iniconfig (2.0.0)
  • Installing mccabe (0.6.1)
  • Installing pluggy (1.2.0)
  • Installing py (1.11.0)
  • Installing pycodestyle (2.7.0)
  • Installing pyflakes (2.3.1)
  • Installing six (1.16.0)
  • Installing sphinxcontrib-jquery (4.1)
  • Installing virtualenv (20.24.7)
  • Installing coverage (7.2.7)
  • Installing flake8 (3.9.2)
  • Installing pytest (7.4.3)
  • Installing sphinx-copybutton (0.4.0)
  • Installing sphinx-rtd-theme (1.3.0)
  • Installing sphinx-tabs (3.4.4)
  • Installing sphinxcontrib-mermaid (0.7.1)
  • Installing tox (3.28.0)

Installing the current project: autodoc_pydantic (2.0.2)
daquintero@dxps:~/flexcompute/autodoc_pydantic$ poetry run python3 -m sphinx docs/source/ docs/build
Running Sphinx v5.3.0
making output directory... done

@daquinteroflex
Copy link

I believe it should be merged and a new release distributed if possible! You're doing amazing work and it's very appreciated

@mansenfranzen
Copy link
Owner

Thanks for the PR! Sorry for taking so long but I will soon merge it once the CI pipeline succeeds.

@mansenfranzen mansenfranzen self-assigned this Dec 8, 2023
@mansenfranzen mansenfranzen added the enhancement New feature or request label Dec 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e476d8b) 0.00% compared to head (7dd2715) 95.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##            main     #177       +/-   ##
==========================================
+ Coverage   0.00%   95.84%   +95.84%     
==========================================
  Files         12       12               
  Lines       1035     1035               
==========================================
+ Hits           0      992      +992     
+ Misses      1035       43      -992     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mansenfranzen mansenfranzen added this to the 2.1 milestone Dec 25, 2023
Copy link
Owner

@mansenfranzen mansenfranzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing the PR and testing it!

@mansenfranzen mansenfranzen merged commit e30b06b into mansenfranzen:main Dec 27, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package not honoring sphinxcontrib namespace package structure
4 participants