-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore model_computed_fields #202
Conversation
@mansenfranzen this is a pretty simple fix, can this be please merged? |
Looks like Would you like to add it to this PR as well, or should I make another one? |
It's no problem - I've added it |
Test fails unrelated I guess |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
=======================================
Coverage 95.84% 95.85%
=======================================
Files 12 12
Lines 1036 1038 +2
=======================================
+ Hits 993 995 +2
Misses 43 43 ☔ View full report in Codecov by Sentry. |
Yes, test fails are unrelated and have been addressed in #190. |
I added a test case for |
@all-contributors please add @tasansal for idea |
I've put up a pull request to add @tasansal! 🎉 |
Changed like suggested in #201