Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore model_computed_fields #202

Merged
merged 8 commits into from
Mar 11, 2024

Conversation

spacemanspiff2007
Copy link
Contributor

Changed like suggested in #201

@tasansal
Copy link

tasansal commented Mar 4, 2024

@mansenfranzen this is a pretty simple fix, can this be please merged?

@tasansal
Copy link

tasansal commented Mar 5, 2024

@spacemanspiff2007

Looks like settings_customise_sources class method of PydanticSettings is also having a similar issue, should be ignore but it shows up in documentation.

Would you like to add it to this PR as well, or should I make another one?

@spacemanspiff2007
Copy link
Contributor Author

It's no problem - I've added it

@spacemanspiff2007
Copy link
Contributor Author

Test fails unrelated I guess

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.85%. Comparing base (1d14f12) to head (29fa653).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   95.84%   95.85%           
=======================================
  Files          12       12           
  Lines        1036     1038    +2     
=======================================
+ Hits          993      995    +2     
  Misses         43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mansenfranzen
Copy link
Owner

Yes, test fails are unrelated and have been addressed in #190.

@mansenfranzen
Copy link
Owner

I added a test case for settings_customise_sources and moved the the member exclusion from the Model documenter into the Settings documenter class.

@mansenfranzen mansenfranzen merged commit bd45dbf into mansenfranzen:main Mar 11, 2024
15 of 16 checks passed
@mansenfranzen
Copy link
Owner

@all-contributors please add @tasansal for idea

Copy link
Contributor

@mansenfranzen

I've put up a pull request to add @tasansal! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants