Merge pull request #38138 from mantidproject/38136_alfview_crash

Wait for result before removing observers in BatchAlgorithmRunner destructor

docs/source/release/v6.11.0/Direct_Geometry/General/Bugfixes/38136.rst

@@ -0,0 +1 @@
+- Fixed a crash on the :ref:`ALF View <ALFView-ref>` when closing the interface while it is loading data.

qt/widgets/common/src/BatchAlgorithmRunner.cpp

@@ -54,7 +54,12 @@ BatchAlgorithmRunner::BatchAlgorithmRunner(QObject *parent)
       m_algorithmErrorObserver(*this, &BatchAlgorithmRunner::handleAlgorithmError),
       m_executeAsync(this, &BatchAlgorithmRunner::executeBatchAsyncImpl) {}
 
-BatchAlgorithmRunner::~BatchAlgorithmRunner() { removeAllObservers(); }
+BatchAlgorithmRunner::~BatchAlgorithmRunner() {
+  Poco::ActiveResult<bool> result = m_executeAsync(Poco::Void());
+  result.wait();
+
+  removeAllObservers();
+}
 
 void BatchAlgorithmRunner::addAllObservers() {
   std::lock_guard<std::recursive_mutex> lock(m_notificationMutex);